Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: check for benchmark regressions on PRs #12027

Merged
merged 7 commits into from
Jan 23, 2025

Conversation

brettlangdon
Copy link
Member

@brettlangdon brettlangdon commented Jan 22, 2025

APMSP-1689

This PR also needs https://github.com/DataDog/benchmarking-platform/pull/125

After merging we will check and block PRs that introduce a microbenchmark regression of >20%.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label Jan 22, 2025
@brettlangdon brettlangdon requested review from a team as code owners January 22, 2025 15:45
Copy link
Contributor

github-actions bot commented Jan 22, 2025

CODEOWNERS have been resolved as:

.gitlab/benchmarks.yml                                                  @DataDog/python-guild @DataDog/apm-core-python

@brettlangdon brettlangdon force-pushed the brettlangdon/bp.regression.check branch 2 times, most recently from 4a5f187 to 78c1715 Compare January 22, 2025 15:54
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jan 22, 2025

Datadog Report

Branch report: brettlangdon/bp.regression.check
Commit report: 4628cbb
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 24.48s Total duration (35m 39.2s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Jan 22, 2025

Benchmarks

Benchmark execution time: 2025-01-23 15:50:42

Comparing candidate commit fdfee2c in PR branch brettlangdon/bp.regression.check with baseline commit ff41c13 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@brettlangdon brettlangdon force-pushed the brettlangdon/bp.regression.check branch from 78c1715 to 5bad2db Compare January 22, 2025 17:19
@brettlangdon brettlangdon requested a review from a team as a code owner January 22, 2025 18:11
@brettlangdon brettlangdon force-pushed the brettlangdon/bp.regression.check branch from df27b2d to 4628cbb Compare January 22, 2025 18:50
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jan 23, 2025

Datadog Report

Branch report: brettlangdon/bp.regression.check
Commit report: fdfee2c
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 26.52s Total duration (35m 39.39s time saved)

@brettlangdon brettlangdon force-pushed the brettlangdon/bp.regression.check branch from 71962d8 to 3c5e650 Compare January 23, 2025 13:15
@ddyurchenko ddyurchenko force-pushed the brettlangdon/bp.regression.check branch from 2df4d92 to f703acc Compare January 23, 2025 14:24
ddtrace/propagation/http.py Outdated Show resolved Hide resolved
ddtrace/propagation/http.py Outdated Show resolved Hide resolved
@brettlangdon brettlangdon enabled auto-merge (squash) January 23, 2025 15:10
@brettlangdon brettlangdon merged commit 47fb797 into main Jan 23, 2025
718 of 720 checks passed
@brettlangdon brettlangdon deleted the brettlangdon/bp.regression.check branch January 23, 2025 19:35
wantsui added a commit that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants