Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(di): add @key and @value to collection expressions #12028

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

P403n1x87
Copy link
Contributor

We add the @key and @value special identifier to allow users to refer to keys and values from a dict-like object.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

We add the `@key` and `@value` special identifier to allow users to
refer to keys and values from a dict-like object.
@P403n1x87 P403n1x87 added changelog/no-changelog A changelog entry is not required for this PR. Dynamic Instrumentation Dynamic Instrumentation/Live Debugger labels Jan 22, 2025
@P403n1x87 P403n1x87 requested a review from a team as a code owner January 22, 2025 16:01
Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/debugging/_expressions.py                                       @DataDog/debugger-python
tests/debugging/test_expressions.py                                     @DataDog/debugger-python

@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: chore/di-expr-key-value-dict
Commit report: 6d744a2
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 28.42s Total duration (35m 34.78s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Jan 22, 2025

Benchmarks

Benchmark execution time: 2025-01-22 16:41:16

Comparing candidate commit 6d744a2 in PR branch chore/di-expr-key-value-dict with baseline commit cd6422a in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. Dynamic Instrumentation Dynamic Instrumentation/Live Debugger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant