-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci_visibility): make pytest v2 plugin the default version #12066
feat(ci_visibility): make pytest v2 plugin the default version #12066
Conversation
|
Datadog ReportBranch report: ✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 57.93s Total duration (35m 44.53s time saved) |
BenchmarksBenchmark execution time: 2025-02-03 11:28:45 Comparing candidate commit 4d60ace in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics. |
880e7da
to
5b86be4
Compare
Previously, the pytest v2 plugin was disabled by default, and could be enabled by setting the
DD_PYTEST_USE_NEW_PLUGIN_BETA
variable to true. In ddtrace 3.0, the pytest v2 plugin will be enabled by default, andDD_PYTEST_USE_NEW_PLUGIN_BETA
will not be used anymore.For now I'm not removing the code for the old plugin version. Instead, I'm adding an internal environment variable
_DD_PYTEST_USE_LEGACY_PLUGIN
that allows running pytest with the old plugin, and using that in the tests that depend on it. We can remove the code (and the variable) after the 3.x release, since this is not part of the public interface.Checklist
Reviewer Checklist