-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(llmobs): [MLOB-2093] remove deprecated parameters arg from annotate method #12085
chore(llmobs): [MLOB-2093] remove deprecated parameters arg from annotate method #12085
Conversation
|
Datadog ReportBranch report: ✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 45.52s Total duration (36m 17.1s time saved) |
BenchmarksBenchmark execution time: 2025-01-28 18:35:17 Comparing candidate commit f67b03e in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics. |
releasenotes/notes/remove-llmobs-parameters-annotation-97406f9cece3fac4.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/remove-llmobs-parameters-annotation-97406f9cece3fac4.yaml
Outdated
Show resolved
Hide resolved
…cece3fac4.yaml Co-authored-by: Yun Kim <[email protected]>
…cece3fac4.yaml Co-authored-by: Yun Kim <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just remember to change the base branch to 3.x-staging
😄
Deprecates the
parameters
arg for the LLMObs annotation method in favor ofmetadata
.I verified this change by running the following code:
Which produced the following error as expected:
TypeError: LLMObs.annotate() got an unexpected keyword argument 'parameters'
.Replacing
parameters
withmetadata
resolves the issue:Checklist
Reviewer Checklist