Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): migrate Appsec fastapi tests #12196

Merged
merged 5 commits into from
Feb 4, 2025
Merged

chore(ci): migrate Appsec fastapi tests #12196

merged 5 commits into from
Feb 4, 2025

Conversation

avara1986
Copy link
Member

@avara1986 avara1986 commented Feb 3, 2025 •
edited
Loading

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@avara1986 avara1986 added the ASM Application Security Monitoring label Feb 3, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

CODEOWNERS have been resolved as:

tests/appsec/integrations/fastapi_tests/__init__.py                     @DataDog/asm-python
tests/appsec/integrations/fastapi_tests/app.py                          @DataDog/asm-python
tests/appsec/integrations/fastapi_tests/conftest.py                     @DataDog/asm-python
hatch.toml                                                              @DataDog/python-guild
tests/appsec/integrations/fastapi_tests/test_fastapi_appsec.py          @DataDog/asm-python
tests/appsec/integrations/fastapi_tests/test_fastapi_appsec_iast.py     @DataDog/asm-python

randomanderson and others added 3 commits February 4, 2025 09:09
@randomanderson @brettlangdon @avara1986
chore(ci): skip non-linux OCI package creation (#12036)
df8a701 
The shared pipeline is introducing support for windows OCI packages.
This PR ensure dd-trace-py doesn't generate nonsensical packages.
Windows support can be added later.

This was tested by using the WIP branch of one-pipeline

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

---------

Co-authored-by: Brett Langdon <[email protected]>
@avara1986
chore(ci): migrate Appsec fastapi tests
b945b62
@avara1986
Revert "chore(ci): skip non-linux OCI package creation (#12036)"
8657bba 
This reverts commit df8a701.
@avara1986 avara1986 force-pushed the avara1986/APPSEC-56667-migrate-fastapi_tests branch from 8bba3a0 to 8657bba Compare February 4, 2025 08:10
@avara1986 avara1986 changed the base branch from main to 3.x-staging February 4, 2025 08:10
@avara1986 avara1986 added the changelog/no-changelog A changelog entry is not required for this PR. label Feb 4, 2025
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Feb 4, 2025 •
edited
Loading

Datadog Report

Branch report: avara1986/APPSEC-56667-migrate-fastapi_tests
Commit report: d1aadd9
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1184 Skipped, 3m 26.56s Total duration (24m 47.54s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Feb 4, 2025 •
edited
Loading

Benchmarks

Benchmark execution time: 2025-02-04 10:43:50

Comparing candidate commit d1aadd9 in PR branch avara1986/APPSEC-56667-migrate-fastapi_tests with baseline commit eff3155 in branch 3.x-staging.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@avara1986 avara1986 marked this pull request as ready for review February 4, 2025 10:51
@avara1986 avara1986 requested review from a team as code owners February 4, 2025 10:51
@avara1986 avara1986 requested a review from tabgok February 4, 2025 10:51
@avara1986 avara1986 merged commit 2ccaaef into 3.x-staging Feb 4, 2025
732 checks passed
@avara1986 avara1986 deleted the avara1986/APPSEC-56667-migrate-fastapi_tests branch February 4, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufede gnufede gnufede approved these changes

@christophe-papazian christophe-papazian christophe-papazian approved these changes

@tabgok tabgok Awaiting requested review from tabgok tabgok is a code owner automatically assigned from DataDog/python-guild

Assignees
No one assigned
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@avara1986 @gnufede @christophe-papazian @randomanderson