-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tracing): remove deprecated properties and parameters #12199
Conversation
|
BenchmarksBenchmark execution time: 2025-02-04 16:41:02 Comparing candidate commit 514f5f2 in PR branch Found 6 performance improvements and 0 performance regressions! Performance is the same for 388 metrics, 2 unstable metrics. scenario:ratelimiter-defaults
scenario:ratelimiter-high_rate_limit
scenario:ratelimiter-long_window
scenario:ratelimiter-low_rate_limit
scenario:ratelimiter-no_rate_limit
scenario:ratelimiter-short_window
|
b73c911
to
b1e9e58
Compare
Datadog ReportBranch report: ✅ 0 Failed, 130 Passed, 1184 Skipped, 3m 49.42s Total duration (24m 49.77s time saved) |
cc52dd5
to
82f6481
Compare
82f6481
to
a120739
Compare
#12186 removed deprecated parameters from `tracer.configure(...)` and `rate_limiter.allowed(...)` but did not update the microbenchmarks. This PR address this issue. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [ ] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Tracer.configure(...)
method and removes theTracer.sampler
attribute.ddtrace.trace.Tracer
can not be reinitialized.Span.sampled
propertyddtrace.tracer.sampler.rules[].choose_matcher(...)
methodand removes the
timestamp_ns
parameter fromddtrace.internal.rate_limiter.RateLimiter.is_allowed()
.DD_TRACE_METHODS
with the '[]' notation. Ensure DD_TRACE_METHODS use the ':' notation instead".ddtracer
parameter fromddtrace.opentracer.tracer.Tracer()
.Checklist
Reviewer Checklist