Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(profiling): serialisable stack key #8435

Merged
merged 1 commit into from
Mar 6, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(profiling): serialisable stack key
Ensure that the stack key used to group events is actually hashable.
P403n1x87 committed Mar 6, 2024
commit bb8832ac752ee0e56e8243d3383f9bb11f2bbafc
9 changes: 8 additions & 1 deletion ddtrace/profiling/exporter/pprof.pyx
Original file line number Diff line number Diff line change
@@ -13,6 +13,7 @@ from ddtrace.internal import packages
from ddtrace.internal._encoding import ListStringTable as _StringTable
from ddtrace.internal.compat import ensure_text
from ddtrace.internal.datadog.profiling.ddup.utils import sanitize_string
from ddtrace.internal.logger import get_logger
from ddtrace.internal.utils import config
from ddtrace.profiling import event
from ddtrace.profiling import exporter
@@ -23,6 +24,9 @@ from ddtrace.profiling.collector import stack_event
from ddtrace.profiling.collector import threading


log = get_logger(__name__)


if hasattr(typing, "TypedDict"):
Package = typing.TypedDict(
"Package",
@@ -129,7 +133,10 @@ cdef groupby(object collection, object key):
cdef dict groups = {}

for item in collection:
groups.setdefault(key(item), []).append(item)
try:
groups.setdefault(key(item), []).append(item)
except Exception:
log.warning("Failed to group item %r", item, exc_info=True)

return groups.items()

Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
fixes:
- |
profiling: handle unexpected stack data to prevent the profiler from
stopping.