feat(profiling): add experimental outside-in stack sampling method (stack v2)

ddtrace/internal/datadog/profiling/cmake/AnalysisFunc.cmake

@@ -0,0 +1,30 @@
+include(FindCppcheck)
+
+function(add_ddup_config target)
+    target_compile_options(${target} PRIVATE
+      "$<$<CONFIG:Debug>:-Og -ggdb3>"
+      "$<$<CONFIG:Release>:-Os>"
+      -ffunction-sections -fno-semantic-interposition -Wall -Werror -Wextra -Wshadow -Wnon-virtual-dtor -Wold-style-cast
+    )
+    target_link_options(${target} PRIVATE
+      "$<$<CONFIG:Release>:-s>"
+      -Wl,--as-needed -Wl,-Bsymbolic-functions -Wl,--gc-sections
+    )
+    set_property(TARGET ${target} PROPERTY INTERPROCEDURAL_OPTIMIZATION TRUE)
+
+    # Propagate sanitizers
+    if (SANITIZE_OPTIONS)
+        # Some sanitizers (or the analysis--such as symbolization--tooling thereof) work better with frame
+        # pointers, so we include it here.
+        target_compile_options(${target} PRIVATE -fsanitize=${SANITIZE_OPTIONS} -fno-omit-frame-pointer)
+        target_link_options(${target} PRIVATE -fsanitize=${SANITIZE_OPTIONS})
+    endif()
+
+    # If DO_FANALYZER is specified and we're using gcc, then we can use -fanalyzer
+    if (DO_FANALYZER AND CMAKE_CXX_COMPILER_ID MATCHES "GNU")
+      target_compile_options(${target} PRIVATE -fanalyzer)
+    endif()
+
+    # If DO_CPPCHECK is specified, then we can use cppcheck
+    add_cppcheck_target(cppcheck_dd_${target} ${CMAKE_CURRENT_SOURCE_DIR})
+endfunction()

ddtrace/internal/datadog/profiling/cmake/FindLibdatadog.cmake

@@ -1,7 +1,14 @@
+# Only add this project if Datadog::Profiling is not already defined
+if(TARGET Datadog::Profiling)
+    return()
+endif()
+
+include(ExternalProject)
 set(TAG_LIBDATADOG
     "v5.0.0"
     CACHE STRING "libdatadog github tag")
 
+set(Datadog_BUILD_DIR ${CMAKE_CURRENT_BINARY_DIR}/libdatadog)
 set(Datadog_ROOT ${Datadog_BUILD_DIR}/libdatadog-${TAG_LIBDATADOG})
 
 message(STATUS "${CMAKE_CURRENT_LIST_DIR}/tools/fetch_libdatadog.sh ${TAG_LIBDATADOG} ${Datadog_ROOT}")

ddtrace/internal/datadog/profiling/dd_wrapper/CMakeLists.txt

@@ -4,36 +4,17 @@ project(dd_wrapper
     LANGUAGES CXX
 )
 
-# Infer some basic properties about the build.  This is necessary because multiple
-# extensions reuse this cmake file, so we need its artifacts to go in a consistent
-# place
-get_filename_component(dd_wrapper_BUILD_PARENT "${CMAKE_BINARY_DIR}/../.." ABSOLUTE)
-set(dd_wrapper_BUILD_DIR "${dd_wrapper_BUILD_PARENT}/ddtrace.internal.datadog.profiling")
+# Build in a predictable location.  This is needed for setup.py
+get_filename_component(dd_wrapper_BUILD_DIR "${CMAKE_CURRENT_SOURCE_DIR}/../ddtrace.internal.datadog.profiling" ABSOLUTE)
 
 # Custom modules are in the parent directory
 list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/../cmake")
 
-# Setup state for FindLibdatadog
-set(Datadog_BUILD_DIR "${dd_wrapper_BUILD_PARENT}/libdatadog")
-
 # Includes
-include(CMakePackageConfigHelpers) # For generating the config file
 include(FetchContent)
 include(ExternalProject)
 include(FindLibdatadog)
-include(FindCppcheck)
-
-# Send some of these vars back up to the parent
-if (DD_WRAPPER_IS_SUBPROJECT)
-  set(Datadog_INCLUDE_DIRS "${Datadog_INCLUDE_DIRS}" PARENT_SCOPE)
-  set(dd_wrapper_BUILD_DIR "${dd_wrapper_BUILD_PARENT}/ddtrace.internal.datadog.profiling" PARENT_SCOPE)
-endif()
-
-add_compile_options(
-  "$<$<CONFIG:Debug>:-Og;-ggdb3>"
-  "$<$<CONFIG:Release>:-Os -s>"
-  -fno-semantic-interposition -Wall -Werror -Wextra -Wshadow -Wnon-virtual-dtor -Wold-style-cast
-)
+include(AnalysisFunc)
 
 # Library sources
 add_library(dd_wrapper SHARED
@@ -45,19 +26,17 @@ add_library(dd_wrapper SHARED
     src/interface.cpp
 )
 
+# Add common configuration flags
+add_ddup_config(dd_wrapper)
+
 # At present, C++17 is chosen as the minimum standard. This conflicts with the
 # manylinux2014 standard upon which we must rely. We'll have to statically link
 # libstdc++ to avoid this conflict, but need to remain mindful of symbol visibility
 # and overall binary size.
 target_compile_features(dd_wrapper PUBLIC cxx_std_17)
 
-# Set some linker options
-target_compile_options(dd_wrapper PRIVATE -fno-semantic-interposition)
-target_compile_options(dd_wrapper PRIVATE -ffunction-sections -fdata-sections)
+# Statically link libstdc++ to avoid manylinux2014 conflicts
 target_link_options(dd_wrapper PRIVATE -static-libstdc++)
-target_link_options(dd_wrapper PRIVATE -Wl,-Bsymbolic-functions)
-target_link_options(dd_wrapper PRIVATE -Wl,--gc-sections)
-set_property(TARGET dd_wrapper PROPERTY INTERPROCEDURAL_OPTIMIZATION TRUE)
 
 target_include_directories(dd_wrapper PRIVATE
     include
@@ -73,32 +52,13 @@ set_target_properties(dd_wrapper
     LIBRARY_OUTPUT_DIRECTORY "${dd_wrapper_BUILD_DIR}"
 )
 
-# If DO_FANALYZER is specified and we're using gcc, then we can use -fanalyzer
-if (DO_FANALYZER AND CMAKE_CXX_COMPILER_ID MATCHES "GNU")
-  target_compile_options(dd_wrapper PRIVATE -fanalyzer)
+# If LIB_INSTALL_DIR is set, install the library
+if (LIB_INSTALL_DIR)
+    install(TARGETS dd_wrapper
+        DESTINATION "${LIB_INSTALL_DIR}"
+    )
 endif()
 
-# If DO_CPPCHECK is specified, then we can use cppcheck
-add_cppcheck_target(cppcheck_dd_wrapper ${CMAKE_CURRENT_SOURCE_DIR})
-
-# Propagate sanitizers
-if (SANITIZE_OPTIONS)
-    # Some sanitizers (or the analysis--such as symbolization--tooling thereof) work better with frame
-    # pointers, so we include it here.
-    target_compile_options(dd_wrapper PRIVATE -fsanitize=${SANITIZE_OPTIONS} -fno-omit-frame-pointer)
-    target_link_options(dd_wrapper PRIVATE -fsanitize=${SANITIZE_OPTIONS})
-endif()
-
-# If dd_wrapper_INSTALL_DIR is specified by the parent, use it
-if (NOT dd_wrapper_INSTALL_DIR)
-  # If not, then just keep it in the build directory
-  set(dd_wrapper_INSTALL_DIR "${CMAKE_BINARY_DIR}/lib")
-endif()
-message(STATUS "dd_wrapper_INSTALL_DIR: ${dd_wrapper_INSTALL_DIR}")
-install(TARGETS dd_wrapper
-    DESTINATION ${dd_wrapper_INSTALL_DIR}
-)
-
 # Add the tests
 if (BUILD_TESTING)
     enable_testing()