Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(sqlalchemy): upgrade tests to support latest versions of sqlalchemy #8480

Merged
merged 4 commits into from
Mar 1, 2024

Conversation

zarirhamza
Copy link
Contributor

@zarirhamza zarirhamza commented Feb 21, 2024

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.
  • If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Feb 21, 2024

Datadog Report

Branch report: zarir/sqlalchemy-upgrade-version
Commit report: 7f7642c
Test service: dd-trace-py

✅ 0 Failed, 171335 Passed, 1037 Skipped, 11m 19.5s Wall Time
❄️ 1 New Flaky

New Flaky Tests (1)

  • test_send_timed_events - test_llmobs_writer.py - Last Failure

    Expand for error
     Calls not found.
     Expected: [call('sent %d LLMObs events to %r', 1, 'https://llmobs-intake.datad0g.com/api/v2/llmobs')]
     Actual: [call('sent %d LLMObs events to %r', 1, 'https://llmobs-intake.datad0g.com/api/v2/llmobs')]
    

@zarirhamza zarirhamza added the changelog/no-changelog A changelog entry is not required for this PR. label Feb 29, 2024
@zarirhamza zarirhamza marked this pull request as ready for review February 29, 2024 22:08
@zarirhamza zarirhamza requested review from a team as code owners February 29, 2024 22:08
@pr-commenter
Copy link

pr-commenter bot commented Feb 29, 2024

Benchmarks

Benchmark execution time: 2024-02-29 22:56:24

Comparing candidate commit 6a8240a in PR branch zarir/sqlalchemy-upgrade-version with baseline commit 67e86b2 in branch main.

Found 9 performance improvements and 10 performance regressions! Performance is the same for 184 metrics, 9 unstable metrics.

scenario:coreapiscenario-context_with_data_listeners_and_all_listeners

  • 🟥 max_rss_usage [+830.980KB; +997.475KB] or [+2.862%; +3.435%]

scenario:coreapiscenario-context_with_data_no_listeners

  • 🟩 max_rss_usage [-857.720KB; -682.786KB] or [-2.859%; -2.276%]

scenario:coreapiscenario-core_dispatch_no_listeners

  • 🟩 max_rss_usage [-826.685KB; -666.307KB] or [-2.759%; -2.224%]

scenario:coreapiscenario-core_dispatch_only_all_listeners

  • 🟩 max_rss_usage [-804.974KB; -619.206KB] or [-2.687%; -2.067%]

scenario:coreapiscenario-core_dispatch_with_results_no_listeners

  • 🟩 max_rss_usage [-842.269KB; -660.963KB] or [-2.810%; -2.205%]

scenario:coreapiscenario-core_dispatch_with_results_only_all_listeners

  • 🟥 max_rss_usage [+823.897KB; +998.413KB] or [+2.838%; +3.439%]

scenario:coreapiscenario-get_item_exists

  • 🟩 max_rss_usage [-811.136KB; -666.701KB] or [-2.708%; -2.226%]

scenario:coreapiscenario-get_item_missing

  • 🟩 max_rss_usage [-782.088KB; -604.408KB] or [-2.611%; -2.018%]

scenario:coreapiscenario-set_item

  • 🟩 max_rss_usage [-786.863KB; -620.522KB] or [-2.625%; -2.070%]

scenario:httppropagationextract-empty_headers

  • 🟩 max_rss_usage [-1059.732KB; -933.792KB] or [-3.530%; -3.111%]

scenario:httppropagationextract-none_propagation_style

  • 🟥 max_rss_usage [+655.986KB; +778.023KB] or [+2.237%; +2.653%]

scenario:httppropagationextract-tracecontext_headers

  • 🟥 max_rss_usage [+640.940KB; +746.784KB] or [+2.183%; +2.543%]

scenario:httppropagationextract-valid_headers_all

  • 🟥 max_rss_usage [+893.250KB; +994.596KB] or [+3.070%; +3.418%]

scenario:httppropagationextract-wsgi_invalid_priority_header

  • 🟩 max_rss_usage [-756.401KB; -641.973KB] or [-2.523%; -2.141%]

scenario:httppropagationextract-wsgi_invalid_trace_id_header

  • 🟥 max_rss_usage [+687.285KB; +801.201KB] or [+2.346%; +2.735%]

scenario:httppropagationextract-wsgi_large_valid_headers_all

  • 🟥 max_rss_usage [+818.664KB; +947.531KB] or [+2.809%; +3.252%]

scenario:httppropagationextract-wsgi_medium_valid_headers_all

  • 🟥 max_rss_usage [+858.772KB; +973.369KB] or [+2.950%; +3.344%]

scenario:otelspan-start

  • 🟥 max_rss_usage [+4.413MB; +4.529MB] or [+9.830%; +10.090%]

scenario:span-add-metrics

  • 🟥 max_rss_usage [+25.716MB; +25.840MB] or [+65.766%; +66.082%]

@zarirhamza zarirhamza enabled auto-merge (squash) March 1, 2024 14:57
@zarirhamza zarirhamza merged commit c00d02e into main Mar 1, 2024
132 checks passed
@zarirhamza zarirhamza deleted the zarir/sqlalchemy-upgrade-version branch March 1, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants