Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iast): remove unneeded atexit handler #8565

Merged
merged 10 commits into from
Mar 4, 2024
Merged

fix(iast): remove unneeded atexit handler #8565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
32ef376
test no native
gnufede Feb 29, 2024
d6724f6
fix(iast): remove initializer.reset from atexit handler
gnufede Mar 1, 2024
48add02
fix(iast): remove atexit handler
gnufede Mar 1, 2024
bd30850
Merge branch 'main' into gnufede/test-no-initializer-reset
gnufede Mar 1, 2024
91c5731
add release note
gnufede Mar 1, 2024
e8494a7
Merge branch 'main' into gnufede/test-no-initializer-reset
gnufede Mar 1, 2024
d5e1baa
Merge branch 'main' into gnufede/test-no-initializer-reset
gnufede Mar 4, 2024
1ffe6e0
Merge branch 'main' into gnufede/test-no-initializer-reset
gnufede Mar 4, 2024
469665a
Merge branch 'main' into gnufede/test-no-initializer-reset
gnufede Mar 4, 2024
ecb98e4
Merge branch 'main' into gnufede/test-no-initializer-reset
gnufede Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions ddtrace/appsec/_iast/_taint_tracking/_native.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,6 @@ PYBIND11_MODULE(_native, m)
{
initializer = make_unique<Initializer>();
initializer->create_context();
// Cleanup code to be run at the end of the interpreter lifetime:
auto atexit = py::module::import("atexit");
atexit.attr("register")(py::cpp_function([] { initializer.reset(); }));

m.doc() = "Native Python module";

Expand Down
4 changes: 4 additions & 0 deletions releasenotes/notes/iast-fix-remove-unneeded-atexit-handler-2a2f7e193c457666.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
fixes:
- |
Vulnerability Management for Code-level (IAST): Fixes an issue where an atexit handler could lead to a segmentation fault.
Loading