-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tracing): remove atexit dead code and forksafe dead code #8573
chore(tracing): remove atexit dead code and forksafe dead code #8573
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 170515 Passed, 1045 Skipped, 10m 32.39s Wall Time |
BenchmarksBenchmark execution time: 2024-03-04 17:28:11 Comparing candidate commit 0934f71 in PR branch Found 17 performance improvements and 14 performance regressions! Performance is the same for 172 metrics, 9 unstable metrics. scenario:coreapiscenario-context_with_data_listeners
scenario:coreapiscenario-context_with_data_no_listeners
scenario:coreapiscenario-context_with_data_only_all_listeners
scenario:coreapiscenario-core_dispatch_listeners
scenario:coreapiscenario-core_dispatch_listeners_and_all_listeners
scenario:coreapiscenario-core_dispatch_no_listeners
scenario:coreapiscenario-core_dispatch_only_all_listeners
scenario:coreapiscenario-core_dispatch_with_results_listeners
scenario:coreapiscenario-core_dispatch_with_results_no_listeners
scenario:coreapiscenario-get_item_missing
scenario:coreapiscenario-set_item
scenario:httppropagationextract-all_styles_all_headers
scenario:httppropagationextract-b3_headers
scenario:httppropagationextract-b3_single_headers
scenario:httppropagationextract-invalid_priority_header
scenario:httppropagationextract-tracecontext_headers
scenario:httppropagationextract-wsgi_empty_headers
scenario:httppropagationextract-wsgi_invalid_priority_header
scenario:httppropagationextract-wsgi_invalid_span_id_header
scenario:httppropagationextract-wsgi_large_header_no_matches
scenario:httppropagationextract-wsgi_medium_header_no_matches
scenario:httppropagationextract-wsgi_valid_headers_all
scenario:httppropagationinject-with_all
scenario:otelspan-start
scenario:samplingrules-average_match
scenario:sethttpmeta-no-collectipvariant
scenario:sethttpmeta-obfuscation-no-query
scenario:sethttpmeta-obfuscation-send-querystring-disabled
scenario:sethttpmeta-obfuscation-worst-case-implicit-query
scenario:sethttpmeta-useragentvariant_not_exists_1
scenario:span-add-metrics
|
In python 3.7 (what we support currently on main)
hasattr(atexit, "unregister")
is always true, so we don't need to check it.hasattr(os, "register_at_fork")
is also ways true, so we don't need to check it.Checklist
changelog/no-changelog
is set@DataDog/apm-tees
.@DataDog/security-design-and-guidance
.Reviewer Checklist