-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): cleanup benchmarking scripts and add profiling capability #9419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettlangdon
added
the
changelog/no-changelog
A changelog entry is not required for this PR.
label
May 28, 2024
brettlangdon
commented
May 28, 2024
emmettbutler
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main change here is adding
viztracer
and a way to generate profiles from benchmark scenario runs.List of changes:
PROFILE_BENCHMARKS=1
env var to trigger generating viztracer profiles for each scenario and putting the results in artifacts directory.
as a ddtrace version to install local version mounted to/src/
in the benchmark container--network host
to allow connecting to a local trace agent for the scenarios which rely on an agent (flask_simple
, etc)pip
is present (not that important, I just saw a version upgrade notice, so figured it doesn't hurt)build_docs
when modifyingbenchmarks/README.rst
since it is included in our docsChecklist
changelog/no-changelog
is set@DataDog/apm-tees
.Reviewer Checklist