feat(onboarding): early exit conditions in lib-injection [backport 2.10] #9512
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 0c38e09 from #9323 to 2.10.
This pull request adds "guardrails" to the "library injection" process. These are early exit conditions from the instrumentation process intended to avoid sending any traces when undefined behavior is likely. The code makes this determination on the basis of software versions present in the application environment, both of Python packages and the Python runtime itself.
The biggest risk here is that instrumentation is disabled when it's not intended to be. I think existing tests in
tests/lib-injection
cover this pretty well. There's a new test added that verifies instrumentation was cancelled when an unsupported package version is present.Contains changes from #9418
Related RFC: "[RFC] One Step Guardrails"
Checklist
DD_TELEMETRY_FORWARDER_PATH
changelog/no-changelog
is set@DataDog/apm-tees
.Reviewer Checklist