Increase type checking coverage #4290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcotc
added
the
dev/internal
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4290 +/- ##
==========================================
- Coverage 97.72% 97.69% -0.03%
==========================================
Files 1355 1355
Lines 82433 82438 +5
Branches 4213 4215 +2
==========================================
- Hits 80555 80536 -19
- Misses 1878 1902 +24 ☔ View full report in Codecov by Sentry. |
p-datadog
approved these changes
Jan 14, 2025
TonyCTHsu
approved these changes
Jan 15, 2025
zarirhamza
approved these changes
Jan 15, 2025
p-datadog
pushed a commit
that referenced
this pull request
Jan 15, 2025
* master: (161 commits) Bump to version 2.9.0 (#4293) Increase type checking coverage (#4290) DEBUG-3329 rename datadog/di/init to datadog/di/preload (#4288) update supported versions workflow (#4289) DEBUG-3182 DI railtie (#4272) DEBUG-3328 report DI status in environment logger summary (#4285) Move out ostruct gem from test group for Ruby 3.5 DEBUG-3316 verify code tracking works in forked processes (#4284) Fix rebase issue in Rack::RequestMiddleware Improve code style in AppSec rack middlewares Improve variable naming in Rack::RequestBodyMiddleware Improve variable naming in Rack::RequestMiddleware Simplify Rack::RequestMiddleware Switch AppSec rack blocking to throw Extract to .gitlab/scripts Implement polling vaccine Update RBS signatures Add new RSpec negate matcher not_change Replace direct AppSec::Processor::Context calls Change AppSec::Context exposed interface ...
|
Nice! Slowly but surely we're getting nice coverage on our typechecks :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable type checking for
span.rb,span_operation.rb,transport/http/builder.rb, andtransport/http/statistics.rb.This PR also simplify 3rd party gem signature declaration (
vendor/rbs), as you now don't need to manually add new folders to theSteepfileanymore.Change log entry
No