Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS-9044] enforcing monitor tags on synthetic tests #25649

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

aliciascott
Copy link
Contributor

@aliciascott aliciascott commented Oct 8, 2024

What does this PR do? What is the motivation?

Merge instructions

  • Please merge after reviewing

Additional notes

@aliciascott aliciascott requested a review from a team as a code owner October 8, 2024 23:03
@aliciascott aliciascott added the WORK IN PROGRESS No review needed, it's a wip ;) label Oct 8, 2024
@github-actions github-actions bot added the Images Images are added/removed with this PR label Oct 8, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Preview links (active after the build_preview check completes)

Modified Files

@aliciascott aliciascott removed the WORK IN PROGRESS No review needed, it's a wip ;) label Oct 21, 2024
Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting some minor updates to address the Vale warnings, as well as some formatting suggestions. Let me know any feedback!

content/en/synthetics/platform/settings/_index.md Outdated Show resolved Hide resolved
content/en/synthetics/platform/settings/_index.md Outdated Show resolved Hide resolved
content/en/synthetics/platform/settings/_index.md Outdated Show resolved Hide resolved
content/en/synthetics/platform/settings/_index.md Outdated Show resolved Hide resolved
Comment on lines 58 to 59
</br>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</br>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be preventing the numbered list below from being indented (which it looks like it's intended to be).

If that's not the intended effect, I think you can update your </br> tag to just <br> or <br/>, as it's a self-closing tag.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @buraizu ! Took a bit of fiddling but I think I got it now, can you re-review ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Images Images are added/removed with this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants