-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS-9044] enforcing monitor tags on synthetic tests #25649
base: master
Are you sure you want to change the base?
Conversation
Preview links (active after the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting some minor updates to address the Vale warnings, as well as some formatting suggestions. Let me know any feedback!
</br> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
</br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be preventing the numbered list below from being indented (which it looks like it's intended to be).
If that's not the intended effect, I think you can update your </br>
tag to just <br>
or <br/>
, as it's a self-closing tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @buraizu ! Took a bit of fiddling but I think I got it now, can you re-review ?
Co-authored-by: Bryce Eadie <[email protected]>
What does this PR do? What is the motivation?
Merge instructions
Additional notes