Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for messages over max packet size limit and throw an exception with the message #65

Merged
merged 6 commits into from
Jun 17, 2019

Conversation

schilling
Copy link
Contributor

Currently such messages trigger a BufferOverflowException (see issue #23) which an error handler could handle, but it wouldn't be given the contents of the message itself. I'm proposing to propagate that on for a consumer to do with as they wish.

@schilling
Copy link
Contributor Author

Will fix up conflicts post #64 being merged.

@schilling
Copy link
Contributor Author

Build failed due to what looks like a timing issue in an existing test. Proposed fix in #72.

@nmuesch
Copy link
Contributor

nmuesch commented Feb 15, 2019

@schilling I'll take a look and review this one, thanks again for your contributions. I merged in #72, could you merge that into this and confirm the CI passes?

@schilling
Copy link
Contributor Author

schilling commented Feb 19, 2019

@schilling I'll take a look and review this one, thanks again for your contributions. I merged in #72, could you merge that into this and confirm the CI passes?

@nmuesch, merged in and the CI passed nicely.

Copy link
Contributor

@gzussa gzussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution 🏅. The implementation looks good to me 😃. Would it be possible to have a more appropriate exception name tho? Not a big deal but it sounds off to me a little 🤷‍♂️

Copy link
Contributor

@gzussa gzussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @schilling 🚀

@schilling
Copy link
Contributor Author

Is there a timeline for inclusion and a publish of the library? It doesn't affect functionality our side at present, but I'd be glad to have an idea of when I should be able to swap over to the upstream library completely.

@dabcoder
Copy link

@schilling sorry for the delay in updating this thread. We should be able to publish a new release sometime in May (we're in the process of changing ownership of that repo team wise). We'll update you once it's done, thanks again for working on that.

@schilling
Copy link
Contributor Author

No worries. Thank you very much for the update.

@derekwbrown derekwbrown merged commit 86af707 into DataDog:master Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants