Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove username references and push to dockerhub #128

Merged
merged 3 commits into from
Aug 15, 2024
Merged

remove username references and push to dockerhub #128

merged 3 commits into from
Aug 15, 2024

Conversation

jackgopack4
Copy link
Contributor

What does this PR do?

removes references to personal dockerhub repositories and personal names. Images pushed to datadog/opentelemetry-examples dockerhub repo with similar tags/names

Motivation

@jackgopack4 jackgopack4 requested a review from a team as a code owner August 14, 2024 16:37
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 14, 2024
View reviewed changes
apps/rest-services/js/database.js Dismissed
@@ -1,7 +1,7 @@
const { Pool } = require('pg');

const pool = new Pool({
user: 'dinesh.gurumurthy',
user: 'otel.sample',

Check failure

Code scanning / CodeQL

Hard-coded credentials Critical

The hard-coded value "otel.sample" is used as
user name
Loading
.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sample user, not used in production

@jackgopack4
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Aug 15, 2024

🚂 MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@jackgopack4
Copy link
Contributor Author

/remove

@dd-devflow
Copy link

dd-devflow bot commented Aug 15, 2024

🚂 Devflow: /remove

@dd-devflow
Copy link

dd-devflow bot commented Aug 15, 2024

⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

If you need support, contact us on Slack #devflow!

@jackgopack4 jackgopack4 merged commit f9d8349 into main Aug 15, 2024
7 checks passed
@jackgopack4 jackgopack4 deleted the jackgopack4/update-dockerhub-refs branch August 15, 2024 13:34
@jackgopack4 jackgopack4 mentioned this pull request Aug 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dineshg13 dineshg13 dineshg13 approved these changes

@ankitpatel96 ankitpatel96 Awaiting requested review from ankitpatel96 ankitpatel96 is a code owner automatically assigned from DataDog/opentelemetry

Assignees
No one assigned
Labels
mergequeue-status: removed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackgopack4 @dineshg13