Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTEL-2058 Update Calendar App image to use the latest multi-platform tag #130

Merged
merged 3 commits into from
Sep 15, 2024

Conversation

krlv
Copy link
Contributor

@krlv krlv commented Aug 27, 2024

What does this PR do?

  • Use the latest datadog/opentelemetry-examples:calendar-java-20240826 multi-platform image tag
  • Switch to imagePullPolicy: Always to prevent cache invalidation issues
  • Introduce nodeSelector: although we can utilize existing affinity/tolerations, the nodeSelector is the simplest recommended form of node selection constraint. It's extremely useful when we want to specify which nodes a pod should be scheduled on based on node labels, but do not need the fine-grained control provided by node affinity.

Motivation

  • Fixing the issues surfaced during bug bash

@krlv krlv requested a review from a team as a code owner August 27, 2024 16:33
@krlv krlv requested a review from dineshg13 August 27, 2024 16:33
# Overrides the image tag whose default is the chart appVersion.
tag: "calendar-java-20240815-01"
tag: "calendar-java-20240826"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can u add script/command you ran to build the image ? so that we use it going forward

@dineshg13 dineshg13 merged commit 0c397b6 into main Sep 15, 2024
7 checks passed
@dineshg13 dineshg13 deleted the krlv/OTEL-2058_multiplatform_tag branch September 15, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants