Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change state machine tag key from DD_XYZ to xyz #553

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

lym953
Copy link
Contributor

@lym953 lym953 commented Nov 7, 2024

Background

#552 sets DD_ENV, DD_SERVICE and DD_VERSION tags on the state machines.

Motivation

From the "custom" approach of instrumenting a state machine, we should set env, service and version, not the DD_XXX ones.

What does this PR do?

Makes plugin set env, service and version tags on the state machine instead of the DD_XXX ones.

Testing Guidelines

Passed the touched tests.

Additional Notes

Need a review from Cloud Tracing team, who, as the downstream consumer, should know what tags should be set here.

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@lym953 lym953 requested a review from a team as a code owner November 7, 2024 19:45
@lym953
Copy link
Contributor Author

lym953 commented Nov 7, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 7, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-07 22:49:47 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 2m.

@dd-mergequeue dd-mergequeue bot merged commit 3d07d2b into main Nov 7, 2024
14 checks passed
@dd-mergequeue dd-mergequeue bot deleted the yiming.luo/set-tags-for-sfn-2 branch November 7, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants