Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dish intern #208
base: main
Are you sure you want to change the base?
Dish intern #208
Changes from 158 commits
c363fa8
85b1902
1c1e51e
e5946b6
2b6647e
105cd11
0dd5405
c6cce20
f4484bc
46cbe48
34d7ebd
1e500ca
7dfeb4f
0a6b98c
9bc2089
9343ce0
0553854
5ebdbaf
29dc8ec
7f5c025
3faacc9
2e18881
ad8005a
842dddc
26b1e65
ff9cb7b
3d9d695
5c32486
41ceeae
4d2f095
98d7016
e53e5a8
9406683
6b5897a
027256b
f0659f5
5a92583
d8c606f
379876e
28b5d36
8e5f784
effa13e
261805b
4ddbd0f
9b0b887
b58d577
d57f7da
c800717
2c707d1
79cdfee
702a82a
dca5bed
56554b6
199694a
042eac8
b9be89c
1e7c4eb
105b07a
1fdc33d
7f4dd1e
e0b99e7
9e27920
f02b6b4
e2dcb1a
9516697
e8fd136
5148f32
908a02a
9fe0ada
36098be
6403c16
31f0e72
2a607ad
75ba84f
5ca0642
dda3d17
c0311c7
c3d88c7
0fb920d
7b721c8
f27dfe4
8f8d5df
92fc96a
38e1e79
b1d62b7
feeaa70
2617113
60773fd
6cead33
a154903
0120413
010330b
eeefe24
d26cffc
681ea11
62e60c7
76339d9
6efbf18
9ca1c3b
4b7c78a
2f03c75
11ccb44
b19b3be
4201764
2e35b5a
1ca3c86
137d247
7c6cf34
b4a8dbb
c3e16a7
9ad2816
72471c5
ab00f8b
bd9a791
880a13b
bbe13cf
4d7e78f
2223dfd
8bde166
304a460
58e15d4
eca4cad
557228c
3684048
1dd12d7
30e6f3c
147469e
919b279
86722f3
1ace223
4da665d
d9d4df4
425ed91
ee76f96
7f68ed9
0c854e4
a6522e2
08d574b
ecbc624
b85b90b
cac62d7
a1997a5
bc2fd79
ccdcd51
77df306
f87b55e
7b6d6e6
f2c0665
64ef7f9
c635354
79dcc63
1a50314
a78c1b5
4dbfac8
f5afbc3
851d65a
b7a7afa
0677f0e
324ac33
047dfef
c5a05e0
69af553
dec44dc
16f53a5
c589905
169466c
de95b8d
78283f0
1831c0e
809a83a
10049dd
f412420
24f4400
cb96f3a
0b1dcbb
ceb4cae
6a38a1c
e3e46f5
d74307d
9e90dd7
833fe4a
9d136d6
1ef137e
26d6988
1312d28
347a06d
9bdde42
dedcf0c
85cb0e7
67c3f13
b915637
764cec0
f313872
7b4b568
ffcbdef
1de503f
35f487e
50fc577
8e702ac
edb55bc
94f9475
7dd5fed
21bd0df
785cd3b
afd8340
b163b5c
7483a7c
e9f54fb
f850776
9965a0e
01aff17
e69d512
a0f8051
4f6a144
76b9468
6661f7d
3b0a7b2
68aff2a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest removing this, as this is only partially being used. All subsequent suggestions reflect this as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
347a06d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the merge, as this is not necessary and only hides the given type error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
26d6988
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the merge and
maxWidth
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
347a06d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the redundant merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
347a06d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
347a06d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently not used. Should be added once needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept it because it was in there before. I do not know for what, though, so I delete it for now: 10049dd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f412420
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it correct that this url should be commited 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
24f4400
cb96f3a
I sent you the new config file in mattermost.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...and changed it back ^^ 1ef137e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
24f4400
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
24f4400
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0b1dcbb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0b1dcbb