-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up main.py #61
Comments
Hey I want to fix this issue im new to github contributor and have good knowledge of python and can you give some context to it |
yeah I can see, it is a bit mess in there, I can help solving it, assign it to me, I will make a PR as soon as I can. |
Oh whoops, github scrolled me to the bottom so I only saw rashid before I assigned. Well, there's another similar ticket so I can assign that one to arnab |
hey @Davidy22 |
sorry for all that mess with commits |
You can run |
@Davidy22 |
@Davidy22 I am having a hard time understanding it and honestly I don't know what can mess wrong, since you have the access to make changes to my Pull Request, please modifying it so it doesn't crash anything. |
I can take a look later after I get some stuff I wanted to clear done, but this should just be a matter of passing a reference to the buffer into the function. |
Still busy with my stuff but it seems like rashid's having trouble with this, I'll assign both of you to this since I think github hasn't pinged arnab for the other ticket I mentioned him in, you can try fix up rashid's attempt or start from scratch. |
Unassigning the two of you since it doesn't seem like this is going to get done. |
Hey. since no one is doing anything about it, I want a chance to do some clearing. Thank you. |
Sure, make the PR and I'll check it to make sure it works. |
main.py has become a bit of a dumping ground, clean it up a little bit by moving what should be moved out into other files.
The text was updated successfully, but these errors were encountered: