Refactored code #71
Refactored code #71
Conversation
|
Just did a checkout and the code crashed immediately on my machine when it entered toggleFlag. Will do a quick skim to see what's happening here, but make sure to run the code to make sure there's no semantic breakage. |
|
|
||
| def toggleFlag(flag: List[int]) -> None: | ||
| """Temp function for toggling video recording from inside screen""" | ||
| vidBuf = Queue(32767) |
There was a problem hiding this comment.
vidBuf is a shared pipe between processes that needs to contain messages between processes, in this case a video filename. If you declare a new buffer in here, the value won't get sent out to the shared buffer outside this function. You can add function parameters if they're needed.
There was a problem hiding this comment.
got it. I will do the testing and will let you know.
There was a problem hiding this comment.
What happened with the testing ?
|
I'm going to close this because it doesn't look like this is going to get finished. If you have a fixed version of this later you can create a new fresh pull request. |
Hi @Davidy22
I did all the pre-commit stuff looks everything good to me now, please have a thorough look and let me know if I need to make other changes,
hopefully later this week I will on creating functions for that lengthy code in main.py also I will make some classes to make thing a little more simple and accessible.
thanks!