Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate guides/models/creating-updating-and-deleting-records.md #211

Closed
wants to merge 2 commits into from
Closed

Translate guides/models/creating-updating-and-deleting-records.md #211

wants to merge 2 commits into from

Conversation

AnChopin
Copy link

@AnChopin AnChopin commented Dec 5, 2023 •
edited
Loading

Closes #95

@AnChopin AnChopin changed the title Start translating Start translating creating-updating-and-deleting-records Dec 5, 2023
@AnChopin AnChopin force-pushed the traduction/creating-updating-and-deleting-records branch from eb631de to 0f45244 Compare December 22, 2023 16:31
@AnChopin AnChopin changed the title Start translating creating-updating-and-deleting-records Translate guides/models/creating-updating-and-deleting-records.md Dec 22, 2023
@AnChopin AnChopin marked this pull request as ready for review December 22, 2023 16:34
MrChocolatine
MrChocolatine reviewed Dec 22, 2023
View reviewed changes
.remarkignore Show resolved Hide resolved
guides/models/creating-updating-and-deleting-records.md Show resolved Hide resolved
guides/models/creating-updating-and-deleting-records.md Show resolved Hide resolved
guides/models/creating-updating-and-deleting-records.md Show resolved Hide resolved
guides/models/creating-updating-and-deleting-records.md Show resolved Hide resolved
guides/models/creating-updating-and-deleting-records.md Show resolved Hide resolved
guides/models/creating-updating-and-deleting-records.md Show resolved Hide resolved
guides/models/creating-updating-and-deleting-records.md Show resolved Hide resolved
guides/models/creating-updating-and-deleting-records.md Show resolved Hide resolved
guides/models/creating-updating-and-deleting-records.md Show resolved Hide resolved
@BlueCutOfficial
Copy link
Member

Awesome PR @AnChopin, thank you 🙏

@BlueCutOfficial BlueCutOfficial added the Guides FR trad File from the Ember Guides to translate in French label Jan 3, 2024
@MrChocolatine
Copy link
Member

MrChocolatine commented Mar 2, 2024 •
edited
Loading

Any update?

@BlueCutOfficial
Copy link
Member

If there's no update on this in the coming week, I'll handle all our comments and merge.

MrChocolatine added a commit that referenced this pull request Apr 28, 2024
@MrChocolatine
chore: apply changes from PR #211 as patch file
0f1dad1 
Resolves #95
@MrChocolatine MrChocolatine mentioned this pull request Apr 28, 2024
Merged
@MrChocolatine
Copy link
Member

@BlueCutOfficial

If there's no update on this in the coming week, I'll handle all our comments and merge.

See => #243

MrChocolatine added a commit that referenced this pull request May 16, 2024
@MrChocolatine
chore: apply changes from PR #211 as patch file
93c6524 
Resolves #95
BlueCutOfficial pushed a commit that referenced this pull request May 17, 2024
@MrChocolatine
Translate guides/models/creating-updating-and-deleting-records.md t…
1714fad 
…o French (#243)

* chore: apply changes from PR #211 as patch file

Resolves #95

* chore: sort lines

Resolves #95

* docs: apply suggestions from comments

Resolves #95

* docs: restrict lines to 100 characters

Resolves #95
@MrChocolatine
Copy link
Member

I am closing this PR as it was replaced by #243 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlueCutOfficial BlueCutOfficial BlueCutOfficial left review comments

@MrChocolatine MrChocolatine MrChocolatine left review comments

Assignees
No one assigned
Labels
Guides FR trad File from the Ember Guides to translate in French
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translate /models/creating-updating-and-deleting-records.md, Ember 4.7
3 participants
@AnChopin @BlueCutOfficial @MrChocolatine