Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort-numbers-group3 #23

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .babelrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"env": {
"test": {
"plugins": ["@babel/plugin-transform-modules-commonjs"]
}
}
}
3 changes: 1 addition & 2 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"plugins": ["jsdoc", "prefer-arrow","sonarjs"],
"plugins": ["jsdoc", "prefer-arrow", "sonarjs"],
"parserOptions": {
"sourceType": "module"
},
Expand Down Expand Up @@ -78,7 +78,6 @@
],
"camelcase": [2, { "properties": "never" }],


"prefer-arrow/prefer-arrow-functions": ["warn"],

"sonarjs/prefer-immediate-return": 0,
Expand Down
6 changes: 6 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,12 @@ title: 'Code Review: challenge name, strategy name'
- request a review
-->

<!-- describe your PR -->

# Description

<!-- A clear and concise description of what the Pull Request is about. -->

Before the reviewer merges this PR to main/master, all of these boxes must be
checked. Only the reviewer can check boxes.

Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,11 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
- name: Use latest LTS Hydrogen Node.js
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
check-latest: true
node-version: 'lts/Hydrogen'

- run: npm install

Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,10 @@ jobs:
steps:
- uses: actions/checkout@v2
- name: Test using Node.js
uses: actions/setup-node@v1
uses: actions/setup-node@v3
with:
node-version: '12'
check-latest: true
node-version: 'lts/Hydrogen'
- run: npm install
- run: npm run test -- ./src
- name: Tests ✅
Expand Down
23 changes: 23 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,25 @@
.vscode/*
!.vscode/settings.json
!.vscode/tasks.json
!.vscode/launch.json
!.vscode/extensions.json
!.vscode/*.code-snippets

# Local History for Visual Studio Code
.history/

# Built Visual Studio Code Extensions
*.vsix

# Dependency directory
# https://docs.npmjs.com/misc/faq#should-i-check-my-node-modules-folder-into-git
node_modules

# Generated by MAC users
**/.DS_Store

# Optional npm cache directory
.npm

plann.txt
coverage
33 changes: 24 additions & 9 deletions .markdownlint.jsonc
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,12 @@
// MD001/heading-increment/header-increment - Heading levels should only increment by one level at a time
"MD001": true,

// Deprecated and disabled
// MD002/first-heading-h1/first-header-h1 - First heading should be a top-level heading
"MD002": {
// Heading level
"level": 1
},
// "MD002": {
// // Heading level
// "level": 1
// },

// MD003/heading-style/header-style - Heading style
"MD003": {
Expand All @@ -28,8 +29,9 @@
// MD005/list-indent - Inconsistent indentation for list items at the same level
"MD005": true,

// Deprecated and disabled
// MD006/ul-start-left - Consider starting bulleted lists at the beginning of the line
"MD006": true,
// "MD006": true,

// MD007/ul-indent - Unordered list indentation
"MD007": {
Expand Down Expand Up @@ -115,9 +117,9 @@
// MD024/no-duplicate-heading/no-duplicate-header - Multiple headings with the same content
"MD024": {
// Only check sibling headings
"allow_different_nesting": false,
"allow_different_nesting": true,
// Only check sibling headings
"siblings_only": false
"siblings_only": true
},

// MD025/single-title/single-h1 - Multiple top-level headings in the same document
Expand Down Expand Up @@ -170,7 +172,20 @@
// MD033/no-inline-html - Inline HTML
"MD033": {
// Allowed elements
"allowed_elements": ["summary", "details", "a", "code", "br"]
"allowed_elements": [
"summary",
"details",
"br",
"strong",
"code",
"em",
"tr",
"td",
"table",
"a",
"sup",
"img"
]
},

// MD034/no-bare-urls - Bare URL used
Expand Down Expand Up @@ -242,7 +257,7 @@

// MD048/code-fence-style - Code fence style
"MD048": {
// Code fence syle
// Code fence style
"style": "consistent"
}
}
35 changes: 35 additions & 0 deletions .vscode/extensions.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
{
// See https://go.microsoft.com/fwlink/?LinkId=827846 to learn about workspace recommendations.
// Extension identifier format: ${publisher}.${name}. Example: vscode.csharp

// List of extensions which should be recommended for users of this workspace.
"recommendations": [
"streetsidesoftware.code-spell-checker",
"dbaeumer.vscode-eslint",
"mhutchie.git-graph",
"donjayamanne.githistory",
"github.vscode-pull-request-github",
"eamodio.gitlens",
"anteprimorac.html-end-tag-labels",
"ritwickdey.liveserver",
"yzhang.markdown-all-in-one",
"davidanson.vscode-markdownlint",
"esbenp.prettier-vscode",
"alefragnani.project-manager",
"stylelint.vscode-stylelint",
"vscode-icons-team.vscode-icons",
"alefragnani.bookmarks",
"bierner.markdown-preview-github-styles",
"ecmel.vscode-html-css",
"htmlhint.vscode-htmlhint",
"pranaygp.vscode-css-peek",
"zignd.html-css-class-completion",
"juanallo.vscode-dependency-cruiser",
"visualstudioexptteam.vscodeintellicode",
"aaron-bond.better-comments",
"christian-kohler.path-intellisense",
"ms-vsliveshare.vsliveshare"
],
// List of extensions recommended by VS Code that should not be recommended for users of this workspace.
"unwantedRecommendations": []
}
117 changes: 117 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,117 @@
{
// https://vscode-docs.readthedocs.io/en/stable/customization/userandworkspace/#default-settings
//-------- Editor configuration --------

// Controls auto save of editors that have unsaved changes.: https://code.visualstudio.com/docs/editor/codebasics#_save-auto-save
"files.autoSave": "onFocusChange",

// Format a file on save. A formatter must be available.
"editor.formatOnSave": true,

// Controls whether the editor should automatically format the pasted content. A formatter must be available.
"editor.formatOnPaste": true,

// Controls whether the editor should render indent quides
"editor.guides.indentation": true,

// Controls whether the editor should highlight the active indent guide.
"editor.guides.highlightActiveIndentation": true,

// Controls the rendering size of tabs in characters. Accepted values: "auto", 2, 4, 6, etc. If set to "auto", the value will be guessed when a file is opened.
"editor.tabSize": 2,

// Defines a default formatter which takes precedence over all other formatter settings. Must be the identifier of an extension contributing a formatter
"editor.defaultFormatter": "esbenp.prettier-vscode",

// Controls bracket pair colorization is enabled or not
"editor.bracketPairColorization.enabled": true,

// Controls whether bracket pair guides are enabled or not. (true, active, false)
"editor.guides.bracketPairs": "active",

// Controls whether horizontal bracket pair guides are enabled or not.
"editor.guides.bracketPairsHorizontal": "active",

// Controls whether the editor should highlight the active bracket pair.
"editor.guides.highlightActiveBracketPair": true,

// Controls whether the editor has linked editing enabled.
"editor.linkedEditing": true,

//-------- HTML configuration --------

// Enable/disable auto closing of HTML tags
"html.autoClosingTags": true,

// Configures if the built-in HTML language suggests HTML5 tags, properties and values.
"html.suggest.html5": true,

// Defines a default HTML formatter which takes precedence over all other formatter settings. Must be the identifier of an extension contributing a formatter
"[html]": {
"editor.defaultFormatter": "vscode.html-language-features"
},

//-------- Emmet configuration --------

// Enables completion when you are writing Emmet appreveation.
"html-css-class-completion.enableEmmetSupport": true,

//-------- JavaScript configuration --------

// Enable/disable auto closing of JSX tags.
"javascript.autoClosingTags": true,

// Enable/disable auto import suggestions.
"javascript.suggest.autoImports": true,

// Enable/disable automatic updating of import paths when you rename or move a file in VS Code.
"javascript.updateImportsOnFileMove.enabled": "always",

// Enable/disable suggestoins for paths in import statement and require calls. (change it to false to be able to use Path Intellisense extension)
"javascript.suggest.paths": false,

//-------- TypeScript configuration --------

// Enable/disable auto closing of JSX tags.
"typescript.autoClosingTags": true,

// Enable/disable auto import suggestions.
"typescript.suggest.autoImports": true,

// Enable/disable automatic updating of import paths when you rename or move a file in VS Code.
"typescript.updateImportsOnFileMove.enabled": "always",

// Enable/disable suggestoins for paths in import statement and require calls. (change it to false to be able to use Path Intellisense extension)
"typescript.suggest.paths": false,

//-------- Work Bench configuration --------

// Controls whether a top border is drawn on tabs for editors that have unsaved changes.
"workbench.editor.highlightModifiedTabs": true,

//-------- Files configuration --------

// When enabled, will trim all new lines after the final new line at the end of the file when saving it.
"files.trimFinalNewlines": true,

// When enabled, insert a new final line at the end of the file when saving it.
"files.insertFinalNewline": true,

//-------- Live Server configuration --------

// Set Custom Port Number of Live Server. Set 0 if you want random port.
"liveServer.settings.port": 5504,

//-------- Markdown configuration --------

// Enable path suggestoins while writing links in markdown files
"markdown.suggest.paths.enabled": true,

// Defines a default markdown formatter which takes precedence over all other formatter settings. Must be the identifier of an extension contributing a formatter
"[markdown]": {
"editor.defaultFormatter": "DavidAnson.vscode-markdownlint"
},

// Enable/disable update table of contents on save
"markdown.extension.toc.updateOnSave": false
}
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ make the transition to collaborative development much smoother.
- Writing Code
- [Repo Setup](#repo-setup)
- [Local Setup](#local-setup)
- [Developing Your Solutions](#developing-your-solution)
- [Developing Your Solutions](#developing-your-solutions)
- [Code Quality Automation](#code-quality-automation)
- [`npm` scripts](#npm-scripts)
- [Code Coverate](#code-coverage)
- [Code Coverage](#code-coverage)
- [Continuous Integration](#continuous-integration)

---
Expand Down
Loading