Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made compatible with Rider 2024.1.5 #32

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

abieganski
Copy link

@abieganski abieganski commented Aug 9, 2024

Hi @DeagleGross, I think I managed to make it compatible with the latest Rider (2024.1.5).

110 files changed, I know... But I had to sort of start from scratch -- get the latest Rider plugin template and copy stuff from your code over into it.

@DeagleGross
Copy link
Owner

Hey,
thanks for contribution.

Why 2024.1.5 is not compatible with an existing code base and you had to re-do it completely? Before it was relatively easy to support new versions: i.e. #27

Also at least - why did you delete a ci pipeline? How can we make sure tests work? :)

@abieganski
Copy link
Author

abieganski commented Aug 9, 2024

Yeah, so I tried to just change the version number and upgrade the nuget packages -- and that's when a nuget package dll hell broke loose. I could not get the packages to not conflict.

Also at least - why did you delete a ci pipeline? How can we make sure tests work? :)

Ooops, this is my first time dealing with a Rider plugin, I knew I'd mess something up.
I put all the tests back in now.

@abieganski
Copy link
Author

OK, I brought back lots of stuff that I missed when copying over.
I think everything should be there now.

@abieganski
Copy link
Author

Hi @DeagleGross, it looks like all the tests have passed. Would you like to publish this version?

@DeagleGross
Copy link
Owner

I don't see any tests being run. Log of CI just says build happened. Maybe i miss something

@abieganski
Copy link
Author

Hi @DeagleGross, me again :)

So I changed tack: reverted to the latest main, and then made the necessary changes in build.gradle etc.

Afterward I had to reference newer versions of the JetBrains nuget packages -- I changed the Nuget package references manually in the csproj files, and was able to get rid of the version conflicts.

Finally, I ran the tests locally and had to make some small adjustments in the *.gold files.

If you could approve the build/CI workflow now, we should be able to see if everything works.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants