Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GLB loader #1

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add GLB loader #1

wants to merge 5 commits into from

Conversation

Kneelawk
Copy link

This PR

This PR adds a simple GLB loader. Expects 1 json chunk and then optionally, 1 bin chunk.

Note: the .editorconfig file is set to remove trailing whitespaces, so that's what my IDE did on all the files I edited.

Testing

This has been tested and correctly loads a simple .glb file containing a cube. This has also been tested loading a very complicated .vrm file and did not error.

@Kneelawk
Copy link
Author

Looks like a bunch of stuff in my VRM file that is not getting loaded yet is part of the GLB specification. I think I'll convert this to a draft for the time-being.

@Kneelawk Kneelawk marked this pull request as draft February 20, 2024 07:42
@Kneelawk
Copy link
Author

Ok, I think the GLB and GLTF additions are pretty solid now.

@Kneelawk Kneelawk marked this pull request as ready for review February 21, 2024 11:28
@Kneelawk
Copy link
Author

Next I'm going to start working on the VRM extensions, but those will be in a different PR which depends on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant