Remove caching from localization keys. Fixes #48

DebuggyTeam · Aug 11, 2023 · 00cecfb · 00cecfb
1 parent 176792d
commit 00cecfb
Showing 1 changed file with 8 additions and 16 deletions.
diff --git a/src/main/java/io/github/debuggyteam/architecture_extensions/TypedGroupedBlockItem.java b/src/main/java/io/github/debuggyteam/architecture_extensions/TypedGroupedBlockItem.java
@@ -21,9 +21,6 @@ public class TypedGroupedBlockItem extends BlockItem implements TypedGrouped {
 
 	protected final TypedGroupedBlock typedGroupedBlock;
 
-	@ClientOnly
-	protected Text cachedLocalization = null;
-
 	public <T extends Block & TypedGrouped> TypedGroupedBlockItem(T block, Settings settings) {
 		super(block, settings);
 		typedGroupedBlock = block.getTypedGroupedBlock();
@@ -57,21 +54,16 @@ private Text getBaseTranslationKey() {
 	@Override
 	@ClientOnly
 	public Text getName() {
-		if (cachedLocalization == null) {
+		String translationKey = Util.createTranslationKey("block", Registries.ITEM.getId(this));
+		if (I18n.hasTranslation(translationKey)) {
+			return Text.translatable(translationKey);
+		} else {
+			Text baseBlock = getBaseTranslationKey();
+			String typedGroupedKey = BLOCK_TYPE_PREFIX + "." + typedGroupedBlock.type().toString();
+			Text blockType = Text.translatable(typedGroupedKey);
 
-			String translationKey = Util.createTranslationKey("block", Registries.ITEM.getId(this));
-			if (I18n.hasTranslation(translationKey)) {
-				cachedLocalization = Text.translatable(translationKey);
-			} else {
-				Text baseBlock = getBaseTranslationKey();
-				String typedGroupedKey = BLOCK_TYPE_PREFIX + "." + typedGroupedBlock.type().toString();
-				Text blockType = Text.translatable(typedGroupedKey);
-
-				cachedLocalization = Text.translatable(BLOCKTYPE_BLOCK_KEY, baseBlock, blockType);
-			}
+			return Text.translatable(BLOCKTYPE_BLOCK_KEY, baseBlock, blockType);
 		}
-
-		return cachedLocalization;
 	}
 
 	@Override