Clean Up Codebase and Start Boulders #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodiertexas
approved these changes
Jul 31, 2022
TibiNonEst
approved these changes
Aug 1, 2022
| @@ -1,38 +1,5 @@ | |||
| package io.github.debuggyteam.wonders.util; | |||
There was a problem hiding this comment.
Is there a reason this file still exists?
There was a problem hiding this comment.
I'm thinking the stuff that used to exist in the utils file got moved or will have a different implementation. Currently this is what exists in the main repo: https://github.com/DebuggyTeam/wonders/blob/1.19/src/main/java/io/github/debuggyteam/wonders/util/WondersUtils.java
There was a problem hiding this comment.
True, however in that case shouldn't it just be yeeted?
There was a problem hiding this comment.
Probably, I'll ask snooze about it on the dev chat since snooze was the one who made the PR.
woodiertexas
approved these changes
Dec 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.