Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add base GitHub CI #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: Add base GitHub CI #4

wants to merge 1 commit into from

Conversation

JanEbbing
Copy link
Member

This adds basic CI to the project

  • Checks for DeepL copyright header on ruby source files
  • Builds the package with rake
  • Linting with rubocop

Tests coming as a second step.
I verified we enabled requiring approval for first-time contributors before running CI, see docs. If this gets abused, we can require approval for all outside contributions as well.

@JanEbbing JanEbbing self-assigned this Oct 2, 2024
@JanEbbing JanEbbing force-pushed the ci/add-gh-ci branch 6 times, most recently from 74fd675 to a7b955b Compare October 3, 2024 15:12
@JanEbbing
Copy link
Member Author

This should work now. I added the false positives gitleaks detects to a .gitleaksignore. If it gets too bothersome we can look into allowlisting e.g. document keys in general. One annoyance with gitleaks is that if it finds a leaked secret, it will not upload the artifact which contains the report file (which would contain the leaked secret, so careful with that). You need to run it locally then to reproduce that and find the secret. Alternatively, one can use the -v option, but needs to be careful - that will leak the secret to the CI logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant