Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add checker to detect 'none' algo in JWT token encode/decode method #122

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore: add checker to detect 'none' algo in JWT token encode/decode method #122

wants to merge 2 commits into from

Conversation

MashyBasker
Copy link
Collaborator

Test logs

Testing built-in rules...
./bin/globstar test -d checkers/
Running test case: dangerous_eval.yml
Running test case: avoid-marksafe.yml
Running test case: context-autoescape-off.yml
Running test case: filter-issafe.yml
Running test case: format-html-param.yml
Running test case: jwt-python-none-alg.yml
Running test case: safe-string-extend.yml
All tests passed%

@vercel Vercel
Copy link

vercel bot commented Feb 25, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
globstar ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 4:48am

@sanket-deepsource
Copy link
Contributor

@MashyBasker Can you add a reference to the source of this vulnerability?

sanket-deepsource
sanket-deepsource requested changes Feb 25, 2025
View reviewed changes
checkers/python/jwt-python-none-alg.yml Outdated
@@ -0,0 +1,42 @@
language: py
name: jwt-python-none-alg
message: Detected the usage of `none` in the algorithms parameter in JWT token
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you refine the message here? Currently, it's describing what we have detected (which is an implementation detail). We should instead tell people what's wrong with their code on an abstract level.

@MashyBasker
Copy link
Collaborator Author

@sanket-deepsource Addressed the requested changes. Please let me know if any additional changes are required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanket-deepsource sanket-deepsource sanket-deepsource requested changes

@sourya-deepsource sourya-deepsource Awaiting requested review from sourya-deepsource

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MashyBasker @sanket-deepsource