fix_lab4 #246
Merged
fix_lab4 #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChengZhang-98
approved these changes
Jan 22, 2025
|
Feel free to merge it if this PR is completed |
omaralkhatib03
pushed a commit
to omaralkhatib03/mase
that referenced
this pull request
Jan 26, 2025
* fix: update dead links * chore!: enable docker access to root/.mase (home/../.mase) * fix: update dead link and fix hardware pass default arg * fix: mark activation inplace argument as boolean * fix: adapt cano changes to emit_parameters_in_mem_internal * fix: fix graph input detection logic and add fixed_linear dependence_files * fix: use ceiling division to determine depth * chore: set seed * debug: add logging * feat: add cano fifo_for_autogen.sv * fix: add missing floor attribute * fix: drive emit_tb with floor integer quantization * chore: rm redundent sv file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr updates
emit_tbto use floor quantization for the fixed type calculation, following the approach already used infixed_linear_tbin MASE. However, it does not test standard integer quantization (nearest rounding). I tried to modifyfixed_linear_tbto use standard integer quantization, but the tests failed, suggesting that thefixed_linearmodule might rely on a hardware module implementing floor rounding. This requires further look in the future. It is enough for lab4 for now.