Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/refactor #50

Open
wants to merge 5 commits into
base: feature/refactor
Choose a base branch
from

Conversation

DarkChaos
Copy link
Contributor

changed sequence of invoke-command to fix Deployment Group issue
Replaced Write-Host with Write-Output (http://www.jsnover.com/blog/2013/12/07/write-host-considered-harmful/)
Fixed #42

@Dejulia489
Copy link
Owner

Write-Host is correct in this situation. It's rare but in this case it is correct because we are truly trying to convey information to the Azure DevOps log host and not the rest of our script/task. Check out PowerShell streams to learn more if you are interested.

Copy link
Owner

@Dejulia489 Dejulia489 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend we stick with Write-Host in this case. I also had a few questions that you could have already tested and are able to answer.
Thanks

@DarkChaos DarkChaos requested a review from Dejulia489 August 18, 2020 16:44
@DarkChaos
Copy link
Contributor Author

@Dejulia489 do you need any more to accept this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants