feature(adds proper WAV codec support): #97
Conversation
PipesNBottles
commented
May 9, 2022
•
PipesNBottles
commented
- uses the extendable media recorder to allow use of WAV and other mime types
- fixes type issues where audio and video tags required undefined rather than null
- fixes issue where if mediaRecorderOptions are supplied the recorder stops recording after first audio blob recording
- uses the extendable media recorder to allow use of WAV and author mime types - fixes type issues where audio and video tags required undefined rather than null - fixes issue where if mediaRecorderOptions are supplied the recorder stops recording after first audio blob recording
|
#96 (comment) |
|
Thanks a ton @PipesNBottles . If possible, could you remove the yarn lock as well? and update the version in 1.6.6 Much thanks! |
|
the lock file has been removed and the version is updated! who merges the changes? I've never contributed to open source before |
|
Hey sorry, got busy with the work stuff. I'll do the merge right now. Thanks for the PR. Really appreciate you taking time to fix it |
|
The only thing I'm worried about this PR is the external dependency. This library is meant to be a minimal one. Since the |
|
I understand the concern, according to the creator of the external project his code sends the actual media stream to a web worker to convert it. https://stackoverflow.com/questions/65191193/media-recorder-save-in-wav-format-across-browsers |
This reverts commit c6c8a35. The added dependency messes up SSR due to the Worker usage
|
@PipesNBottles @0x006F By any chance, does this fix #19? |
