Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Craftable muskets + Flintlocks #1008

Merged
merged 35 commits into from
May 26, 2024

Conversation

Tryded
Copy link
Contributor

@Tryded Tryded commented Mar 25, 2024

About the PR

Makes a Musket meant for DeltaV with its own ammo and crafting recipe.

The Musket has multiple parts that all have to be individually crafted to make the musket.

Why / Balance

Line Infantry will be funny and using the weapon by yourself is kind of bad as it takes 8 seconds to fire again. You can dual wield with the flint locks.

Each Cartridge deals 30 piercing damage.

Technical details

YAML Only

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑 Tryded

  • add: Added a way for muskets and musket cartridges (NOT .60) to be crafted.

@github-actions github-actions bot added Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files labels Mar 25, 2024
Copy link
Contributor

github-actions bot commented Mar 25, 2024

RSI Diff Bot; head commit a49faac merging into fb62f23
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Objects/Misc/bayonet.rsi

State Old New Status
base Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Objects/Misc/modular_breech.rsi

State Old New Status
base Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Objects/Misc/modular_trigger.rsi

State Old New Status
base Added

Resources/Textures/DeltaV/Objects/Weapons/Guns/Ammunition/Casings/musket_casing.rsi

State Old New Status
base Added

Edit: diff updated after a49faac

@Tryded
Copy link
Contributor Author

Tryded commented Mar 25, 2024

Still trying to figure out how to make it reload slower without changing the firerate as the firerate makes it so that it is basically impossible to quickdraw it even when it is already reloaded.

@Tryded
Copy link
Contributor Author

Tryded commented Mar 25, 2024

Ready for review

@Bonktrauma
Copy link
Contributor

Ready for review

Will it still allow .60?

@Tryded
Copy link
Contributor Author

Tryded commented Mar 26, 2024

Will it still allow .60?

It uses it's own musket cartridge which deals 30 pierce and is craftable

@Tryded
Copy link
Contributor Author

Tryded commented Apr 6, 2024

hmm

@Tryded
Copy link
Contributor Author

Tryded commented Apr 19, 2024

Hm.. It's been an while

@Tryded
Copy link
Contributor Author

Tryded commented May 2, 2024

Does anyone have concerns?

@Colin-Tel Colin-Tel enabled auto-merge (squash) May 26, 2024 15:01
@Colin-Tel Colin-Tel merged commit 9618366 into DeltaV-Station:master May 26, 2024
13 checks passed
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 3, 2025
# Description

This PR updates the Localizations relevant to the Reptilian species by
significantly expanding upon them as Unathi, which is how they are
typically referred to as in both /tg/station and Baystation12 derived
codebases in SS13. I have added a new "Rare" language taken from Aurora,
called Azaziba, which can only be taken by Unathi as a bonus language
trait.

Translators for this new language Azaziba are intentionally not
obtainable ingame except as spawned by Admins. This is a "Rare"
language, and shouldn't be accessible to players outside of Unathi
obtaining the trait.

The biggest change in this update however is a massive expansion upon
the Unathi Guidebook entry, providing a significant volume of Lore,
which is largely taken(with slight modifications) from
https://wiki.aurorastation.org/index.php?title=Unathi (Which, I can do
this since their wiki has a Creative Commons license). This is probably
the best way to get good quality lore for them, other than by writing it
myself.

<details><summary><h1>Media</h1></summary>
<p>


![image](https://github.com/user-attachments/assets/842d9c40-3cf3-41ab-a9fe-f0aac81c1bce)


![image](https://github.com/user-attachments/assets/f1ef8090-97a4-46f9-8548-9389606d4e3b)


![image](https://github.com/user-attachments/assets/870ab41c-fe00-45cf-8440-51cfe3f0b164)


![image](https://github.com/user-attachments/assets/09a8548a-cb98-4158-b0a8-e641078ecf80)

</p>
</details>

# Changelog

:cl:
- add: Localizations for Reptilians that acknowledge them now as Unathi.
- add: Azaziba has been added as a new "Rare" language that can only be
taken by Unathi. Translators between Azaziba and Tau-Ceti Basic do not
exist, please do not make them.
- add: SIGNIFICANTLY expanded upon the Guidebook for Unathi by including
a large volume of lore taken from the Aurora Station Wiki.
sleepyyapril added a commit to Simple-Station/Einstein-Engines that referenced this pull request Feb 4, 2025
# Description

## **!!! DO NOT "Squash and commit", ONLY "Create a merge commit" !!!**

Merges a lot of PRs from Delta-V, most of these are plain YML changes so
they shouldn't cause wizmerge-like issues.
- DeltaV-Station/Delta-v#1008 
- DeltaV-Station/Delta-v#1077
- DeltaV-Station/Delta-v#1092
- DeltaV-Station/Delta-v#1094
- DeltaV-Station/Delta-v#1143
  - Excluded the lobby art with DeltaV branding.
- DeltaV-Station/Delta-v#1176
- DeltaV-Station/Delta-v#1209
- DeltaV-Station/Delta-v#1227
- DeltaV-Station/Delta-v#1252
- not directly cherry-picked due to harpy singing now being stored in a
different file, but implemented the same thing in
df50140
- DeltaV-Station/Delta-v#1261
- DeltaV-Station/Delta-v#1271
- DeltaV-Station/Delta-v#1272
- Also made available to Humans and Tajarans like the other Felinid
tails.
- DeltaV-Station/Delta-v#1426
- DeltaV-Station/Delta-v#1462
- DeltaV-Station/Delta-v#1542
- DeltaV-Station/Delta-v#1759
- DeltaV-Station/Delta-v#1763
- DeltaV-Station/Delta-v#1765
- DeltaV-Station/Delta-v#1780
- DeltaV-Station/Delta-v#1781
- DeltaV-Station/Delta-v#1804
- DeltaV-Station/Delta-v#1814
- TODO in another pr, vulp sprite for the colorable neck gaiter (PR only
adds vulp states to pre-existing black/red neck gaiters)
- DeltaV-Station/Delta-v#1828
  - Added to Loadouts for Corpsman, costs 2 points.
- DeltaV-Station/Delta-v#1838
- DeltaV-Station/Delta-v#1877
- DeltaV-Station/Delta-v#1905
  - Added to Loadout Uniforms, costs 1 point. 
- DeltaV-Station/Delta-v#1910
- DeltaV-Station/Delta-v#1935
- DeltaV-Station/Delta-v#1946
- DeltaV-Station/Delta-v#1994
- DeltaV-Station/Delta-v#1997
- DeltaV-Station/Delta-v#1998
- DeltaV-Station/Delta-v#2031
- DeltaV-Station/Delta-v#2089
- DeltaV-Station/Delta-v#2113
- DeltaV-Station/Delta-v#2213
- DeltaV-Station/Delta-v#2209
- DeltaV-Station/Delta-v#2210
- Prerequisite Wizden PR added:
space-wizards/space-station-14#29243
- Prerequisite Wizden PR added:
space-wizards/space-station-14#30856
- DeltaV-Station/Delta-v#2233
- DeltaV-Station/Delta-v#2245
- DeltaV-Station/Delta-v#2250
- DeltaV-Station/Delta-v#2266
- DeltaV-Station/Delta-v#2267
- DeltaV-Station/Delta-v#2294
- DeltaV-Station/Delta-v#2307
- DeltaV-Station/Delta-v#2318
- DeltaV-Station/Delta-v#2398
- DeltaV-Station/Delta-v#2410
- DeltaV-Station/Delta-v#2462
- DeltaV-Station/Delta-v#2478
- DeltaV-Station/Delta-v#2501
- DeltaV-Station/Delta-v#2503
- DeltaV-Station/Delta-v#2504
- Prerequisite Wizden PR added:
space-wizards/space-station-14#30957
- DeltaV-Station/Delta-v#2524
- DeltaV-Station/Delta-v#2539
- DeltaV-Station/Delta-v#2635
- Prerequisite Wizden PR added:
space-wizards/space-station-14#32193
- Prerequisite Wizden PR added:
space-wizards/space-station-14#32327

## Changelog

Too much changes to count so some changes are unlisted

:cl: Several Contributors
- add: Added Lone Digger by Caravan Palace to the jukebox! (by MilonPL)
- add: Added Deck The Halls by Kevin Macleod to the jukebox! (by
Lyndomen)
- tweak: Now medical belts have a slot for medkits. (by Radezolid)
- add: Added a way for muskets, flintlocks, and musket cartridges (NOT
.60) to be crafted. (by Tryded)
- add: Added Vulpkanin-specific sprites to a lot of helmets and masks.
(by Adrian16199, TadJohnson00)
- add: Security dogs (such as Laika) now have Vulpkanin vocal emotes.
Howl! (by Remuchi)
- add: Split the Emag into the Cryptographic Sequencer and the Airlock
Access Override. (by Warmechanic)
- add: Added Corpsman Glasses, no more getting flashed as Corpsman! Also
available in Loadouts. (by Unkn0wnGh0st333)
- add: Harpies can now mimic harps! (by TheOneWhoIsManyFrame)
- tweak: Cats will now play with mouse toys. (by Deltanedas)
- add: Added a black turtleneck, available in Loadouts! (by Aikakakah)
- add: Added the Binary Translator Key to the uplink costing 1 TC and
the listening post operative headset. (by Radezolid)
- add: Spesos now have a new pretty look transferred from the Frontier
Station. (by whatston3)
- add: The home-run bat has been re-added to the traitor uplink.
- add: Added the CrystalThistle, mutated from the Galaxythistle that
generates Quartzite which when heated produces glass sheets. (by
jimmy12or)
- add: Added a Ghost Pepper! A friendly looking Pepper that's so Spicy,
it hurts! (by jimmy12or)
- add: Added a Cosmic Revenant! A spooky mutation of the Ghost pepper
that produced Ectoplasm. (by jimmy12or)
- add: Added blue and purple tomato soup, made using Blue Tomatoes. (by
DisposableCrewmember42)
- add: Added new drinks: the double ice cream (by dge21) and Dr. Gibb
Blood Red (by BlitzTheSquishy).
- add: Some drink reactions now require shaking with the shaker or
stirring with a spoon. (by Vermidia)
- add: Added "Selene" wing customization option for moths (by
boogiebogus)
- add: Added the tiger tail sprite for Felinids, Humans and Tajarans.
(by Adrian16199)
- add: NanoTrasen has established business relations with HydroCo! You
can now order powdered milk and juice via your Logistics department. (by
DisposableCrewmember42)
- tweak: Bar and kitchen shelves no longer restrict the items that can
be placed in them. (by Velcroboy)
- tweak: Bookshelves can now fit any kind of item, not just books. (by
Deltanedas)
- add: New magic crayons have appeared in the sector, artists rejoice!
(by AvalonProto)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants