Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secborg Module Overhaul, Small Borg Buff #2059

Open
wants to merge 34 commits into
base: master
Choose a base branch
from

Conversation

Avalon-Proto
Copy link
Contributor

@Avalon-Proto Avalon-Proto commented Oct 27, 2024

A total rework of secborg modules, and gives all borgs roundstart tools

About the PR

A rework of all the items contained within the modules of the secborg, as well as granting all borgs roundstart tools as not having tools as a borg is just pain

Why / Balance

The pax hypo was an extremely overpowered option, allowing secborgs to completely nullify any chance someone had of fighting back. So, I removed it, moved things around, and now I think the modules are in afar better state

Technical details

Bastion Module- Now contains the Non-lethal launcher and a flash, whistle too
Patrol Module- Contains Seclite, Holobarrier, whistle
De-Escalation- Lost Pax Hypo, Gained a whistle + Seclite
Escalation- Gained Riot shotgun, a 4 shot beanbag shotgun, a combat knife, and a whistle
Chase- Gained Seclite, Whistle, Lost MEG, Gained Disabler.
All borgs gained tools

Media

De-Escalation
image
Patrol
image
Chase
image
Bastion
image
Escalation
image

Requirements

Breaking changes

Changelog

🆑

  • tweak: Secborg equipment has been reassessed and redesigned, go out there and show em what you're made of peacekeepers!
    🆑
  • tweak: ALl borgs have been outfitted with tool modules at base

A total rewqwork of secborg modules
@github-actions github-actions bot added Changes: YML Changes any yml files S: Merge Conflict Fix your PR! labels Oct 27, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Removed patrol module fully
@Avalon-Proto
Copy link
Contributor Author

Patrol Module fried, bastion remains for later repurposing

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Avalon-Proto
Copy link
Contributor Author

Hey Milon. Gonna help me fix the GLs anytime soon? I wanna see this in action

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Nov 24, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the size/M 64-255 lines label Dec 25, 2024
@Avalon-Proto
Copy link
Contributor Author

Why is the commented out bastion causing a conflict I'm getting rid of it :elp:

@Avalon-Proto Avalon-Proto marked this pull request as ready for review December 25, 2024 01:16
@Avalon-Proto Avalon-Proto requested a review from a team as a code owner December 25, 2024 01:16
@MadiMadsen
Copy link

something i was curious about was that there were plans to add a module for zip ties for security borgs. I'm wondering if that could be part of this overhaul or if that's out of scope of your current plans.

@Bonktrauma
Copy link
Contributor

something i was curious about was that there were plans to add a module for zip ties for security borgs. I'm wondering if that could be part of this overhaul or if that's out of scope of your current plans.

Secborgs won't be given any form of restraints iirc

@Avalon-Proto
Copy link
Contributor Author

something i was curious about was that there were plans to add a module for zip ties for security borgs. I'm wondering if that could be part of this overhaul or if that's out of scope of your current plans.

Secborgs won't be given any form of restraints iirc

Correction. If I knew how to I'd give them zip ties. At one point @IamVelcroboy had a working ziptie module

@Radezolid
Copy link
Contributor

something i was curious about was that there were plans to add a module for zip ties for security borgs. I'm wondering if that could be part of this overhaul or if that's out of scope of your current plans.

Secborgs won't be given any form of restraints iirc

Correction. If I knew how to I'd give them zip ties. At one point @IamVelcroboy had a working ziptie module

Pretty much you would need to do this https://github.com/DeltaV-Station/Delta-v/blob/master/Resources/Prototypes/Entities/Objects/Materials/Sheets/glass.yml#L111

@Bonktrauma
Copy link
Contributor

Correction. If I knew how to I'd give them zip ties. At one point @IamVelcroboy had a working ziptie module

https://discord.com/channels/968983104247185448/1206353544186171482/1268113845705244813

I dont think danger wanted them to have cuffs

@ThataKat
Copy link
Contributor

Alrighty, here's what we've got. This is not a list of changes, but a list of how we'd like things to be (assembled this way for our own organization). Point being some of this is already the case, but if you can bring anything that isn't in line that'd be great.

Round start (when borgs pick the chassis):

  • Peacekeeper (no changes)
  • De-escalate (launcher moved out, see below)

Printable round start by epi:

  • Chase (no changes)

Printable under Advanced Riot Control research:

  • Escalate (remove flash)
  • ?New Module? (New module with the flash/EMP launcher and a flash, whistle optional if you want)

We didn't come up with a name for the proposed new module but if you would like us to we can, otherwise up to you! Hopefully editing what modules borgs spawn with isn't too hard, I'm not the most technical on this stuff. Let us know if you have any questions, etc.

@Avalon-Proto
Copy link
Contributor Author

Round start (when borgs pick the chassis):

* Peacekeeper (no changes)

* De-escalate (launcher moved out, see below)

Funny enough, the De-escalation module just makes the peacekeeper worthless, due toth efact its just a better peacekeeper. But changing the module should be easy

Printable round start by epi:

* Chase (no changes)

Yeah that tracks

Printable under Advanced Riot Control research:

* Escalate (remove flash)

Why remove the self charging flash?

* ?New Module? (New module with the flash/EMP launcher and a flash, whistle optional if you want)

I can just make the Bastion module use the launcher, and make that the de-facto crowd control option. Maybe give the Borg a riot shield too? Tho not sure how that would work if the shield is destroyed by damage

We didn't come up with a name for the proposed new module but if you would like us to we can, otherwise up to you! Hopefully editing what modules borgs spawn with isn't too hard, I'm not the most technical on this stuff. Let us know if you have any questions, etc.

@ThataKat
Copy link
Contributor

ThataKat commented Feb 17, 2025

Funny enough, the De-escalation module just makes the peacekeeper worthless, due toth efact its just a better peacekeeper. But changing the module should be easy

I could not find the description/info on the Peacekeeper for the life of me so if it's just useless that's fine, it can go. Although I like having the holoprojector not be in with the baton and such.

Why remove the self charging flash?

Removed the flash from the escalate to streamline it and emphasize the flash in other locations, like the launcher module. Also, almost every module has a flash and it would be good to have some without.

I can just make the Bastion module use the launcher, and make that the de-facto crowd control option. Maybe give the Borg a riot shield too? Tho not sure how that would work if the shield is destroyed by damage

Could use the bastion module as crowd control, sure! A shield is a neat idea but breaking is a concern. It shouldn't be unbreakable since that would be OP, maybe if it was recharging? That might be a big ask, let me know.

I'm not overly concerned about the balance of a shield by itself since the Borg can only hold the shield which just makes it a defensive measure.

Fair warning I'm still checking with other curators about the shield idea so maybe work on the other stuff first. I don't foresee it being an issue though.

@Stop-Signs Stop-Signs mentioned this pull request Feb 17, 2025
2 tasks
@Stop-Signs
Copy link
Contributor

Further direction request: please reduce the extraModuleCount: in Resources/Prototypes/_DV/borg_types.yml to 2

we dont want gamerborg to have the power of all of these at once

@Avalon-Proto
Copy link
Contributor Author

Gave the holo barrier to the patrol module, otherwise its just a Seclite, so at least it can do something

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Feb 18, 2025
@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Feb 18, 2025
@Avalon-Proto
Copy link
Contributor Author

I have no idea why the tests are failing though :agony:

@Avalon-Proto
Copy link
Contributor Author

DIrection changes implemented, I still personally feel taking a module away from secborgs, ON TOP of having less health, is a bit too much, but we will see

@Avalon-Proto Avalon-Proto changed the title Secborg Module Overhaul Secborg Module Overhaul, Small Borg Buff Feb 18, 2025
@Avalon-Proto
Copy link
Contributor Author

@deltanedas Do I need to do anything about the submodule changes - I never opened any of that so I'm not sure why I have things in there

@Toby222
Copy link
Contributor

Toby222 commented Feb 18, 2025

Do I need to do anything about the submodule changes - I never opened any of that so I'm not sure why I have things in there

Seems you missed an update to RobustToolbox when you merged master.
You should be able to go into the folder and switch to the version in master, then recommit with the updated version

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Feb 24, 2025
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Avalon-Proto
Copy link
Contributor Author

Welp... Seeing as how direction asked for the security Borg to be fried, I'll be closing this PR. Don't need to rebalance something that no longer exists

@Lyndomen
Copy link
Contributor

Caught me by surprise too tbh, I didn't know we discussed it. That being said, add these to the syndie exofab

@Avalon-Proto
Copy link
Contributor Author

Caught me by surprise too tbh, I didn't know we discussed it. That being said, add these to the syndie exofab

All of the modules I rebuilt..? Oo. Now that's interesting, but I'll need to swap around the module's base items

@Avalon-Proto Avalon-Proto reopened this Feb 24, 2025
@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review size/M 64-255 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.