Port EE fix to disposal chutes #2198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
S: Needs Review
Changes: C#
deltanedas
requested changes
Nov 15, 2024
deltanedas
reviewed
Nov 15, 2024
| @@ -136,9 +136,9 @@ public void ExitDisposals(EntityUid uid, DisposalHolderComponent? holder = null, | |||
| { | |||
| _xformSystem.AttachToGridOrMap(entity, xform); | |||
|
|
|||
| if (holder.PreviousDirection != Direction.Invalid && _xformQuery.TryGetComponent(xform.ParentUid, out var parentXform)) | |||
| if (holder.PreviousDirection != Direction.Invalid && _xformQuery.TryGetComponent(uid, out var parentXform)) // start DeltaV EE Disposal fix | |||
There was a problem hiding this comment.
the item shot just dissapears if i dont do this change or the one prev committed
There was a problem hiding this comment.
the pipe's WorldRotation and the parent (grid) Should be the exact same, are you sure they are different
There was a problem hiding this comment.
I'm not sure of anything but when I changed it to only edit on line 141, no edit on 139, the objects sit in one place then eventually disappear
|
Closed, being resolved upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Disposal chutes shoot at orientation 0 no matter where they are pointing at now on the grid as i detailed in space-wizards/space-station-14#31459
I would love to PR this upstream but AGPL
ported from Fansana/floofstation1#220
Why / Balance
Important for #1582 and any ship with a disposal cannon
Technical details
tiny 2 line change C#
Media
Requirements
Breaking changes
no
Changelog
🆑