Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random Announcer System [PORT] #2652

Open
wants to merge 37 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
ba41ae6
random announcer system port from einstein engines
Darkmajia Aug 15, 2024
0442f49
robust fixes for announcement issues
Darkmajia Aug 18, 2024
56ff915
doing it sensible style
Darkmajia Aug 18, 2024
a3198f0
multiple announcement sounds, announcer volume fix
Darkmajia Aug 29, 2024
7563c2e
CVars, yay.
Monotheonist Jan 8, 2025
bebd361
The great Einsteins Engineing
Monotheonist Jan 9, 2025
978e690
I am in misery (more Cvars)
Monotheonist Jan 9, 2025
f8809f8
quick fixes for shuttle dock/meteor swarm announcements
Darkmajia Aug 18, 2024
9384659
we're still in hell
Monotheonist Jan 10, 2025
6a65692
end of file newline ops
Monotheonist Jan 14, 2025
6cbfcd6
Oh my goodness it's almost not broken
Monotheonist Jan 14, 2025
3912e45
works now, apparently...?
Monotheonist Jan 14, 2025
a51b3c7
Y'know what, fuck everyone else, lmao!!
Monotheonist Jan 14, 2025
0412d02
Namespaces locale for announcers
Monotheonist Jan 14, 2025
031d7c9
Untested but this might fix the test fails :tm:
Monotheonist Jan 14, 2025
68e5411
don't forget the snails fool
Monotheonist Jan 14, 2025
7e9c1c1
Un-nullable, therefore false.
Monotheonist Jan 14, 2025
94269ea
Gas leak
Monotheonist Jan 14, 2025
437e38b
Sinking ships often leak and I'm plugging the holes with these commits
Monotheonist Jan 14, 2025
afd13e6
Is that everything, Linter?!
Monotheonist Jan 14, 2025
b463728
IT SAID NO!!!!!!!! RAHHHHHHHHHH
Monotheonist Jan 15, 2025
272e448
Probably the final attempt to appease the linter for this (at least I…
Monotheonist Jan 15, 2025
09e025a
Conflictless locale gaming part one (and also adding greytide virus t…
Monotheonist Jan 17, 2025
5b26441
I FORGOT!
Monotheonist Jan 17, 2025
15fd731
Conflictless locale gaming part two
Monotheonist Jan 17, 2025
a701e48
Comments (CS / XAML)
Monotheonist Jan 17, 2025
bc4e520
Finishes locale gaming for real
Monotheonist Jan 17, 2025
a4c6a7f
Pure Idiocy
Monotheonist Jan 17, 2025
9c5de08
Fixing Xenovents error
Monotheonist Jan 18, 2025
6e4ef46
Moving to deltaV files, if we don't want them here we can revert and …
Monotheonist Jan 18, 2025
92ca70a
Attributions YML
Monotheonist Jan 18, 2025
8241f83
Merge branch 'master' into randomannouncersys
Monotheonist Jan 18, 2025
56183a4
THIS DOES NOT HAVE AN ANNOUNCEMENT. IT IS NEVER CALLED.
Monotheonist Jan 18, 2025
2ddd5b0
Merge branch 'randomannouncersys' of https://github.com/Monotheonist/…
Monotheonist Jan 18, 2025
f28f338
Radezolid's review (Incomplete)
Monotheonist Jan 27, 2025
d2d763a
Merge branch 'master' into randomannouncersys
Monotheonist Jan 30, 2025
e5d3f64
Merge branch 'randomannouncersys' of https://github.com/Monotheonist/…
Monotheonist Jan 30, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Is that everything, Linter?!
Monotheonist committed Jan 14, 2025
commit afd13e6a47c65d356967367027c3f978e0a24d14
16 changes: 8 additions & 8 deletions Resources/Prototypes/GameRules/events.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't delete the lines, comment them out with a DeltaV comment stating why it was commented out.
Also state what the locale was before you changed it.

Original file line number Diff line number Diff line change
@@ -129,7 +129,7 @@
parent: BaseGameRule
components:
- type: StationEvent
startAnnouncement: true #Impstation Random Announcer System
startAnnouncement: true # Impstation: Random Announcer System
minimumPlayers: 25
weight: 5
duration: 1
@@ -144,7 +144,7 @@
parent: BaseGameRule
components:
- type: StationEvent
startAnnouncement: true
startAnnouncement: true # Impstation: Random Announcer System
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add to the comment what the locale was before same as the rest of them.

minimumPlayers: 15
weight: 5
duration: 1
@@ -351,7 +351,7 @@
parent: BaseStationEventLongDelay
components:
- type: StationEvent
startAnnouncement: true
startAnnouncement: true # Impstation: Random Announcer System
earliestStart: 20 #DeltaV - was 15
minimumPlayers: 15
weight: 7.5 # DeltaV - was 5
@@ -365,7 +365,7 @@
parent: BaseStationEventShortDelay
components:
- type: StationEvent
startAnnouncement: true
startAnnouncement: true # Impstation: Random Announcer System
earliestStart: 20
minimumPlayers: 15
weight: 5
@@ -384,7 +384,7 @@
parent: BaseStationEventShortDelay
components:
- type: StationEvent
startAnnouncement: station-event-vent-creatures-start-announcement
startAnnouncement: true # Impstation Random Announcer Port
startAudio:
path: /Audio/Announcements/attention.ogg
earliestStart: 20
@@ -405,7 +405,7 @@
parent: BaseStationEventShortDelay
components:
- type: StationEvent
startAnnouncement: true
startAnnouncement: true # Impstation: Random Announcer System
earliestStart: 20
minimumPlayers: 15
weight: 5
@@ -421,7 +421,7 @@
parent: BaseStationEventShortDelay
components:
- type: StationEvent
startAnnouncement: true
startAnnouncement: true # Impstation: Random Announcer System
earliestStart: 45 # DeltaV - was 20
minimumPlayers: 30 # DeltaV - was 20
weight: 1 # DeltaV - was 1.5
@@ -515,7 +515,7 @@
weight: 5 # DeltaV - Was 8 now 5
minimumPlayers: 15
maxOccurrences: 1 # can only happen once per round
startAnnouncement: true
startAnnouncement: true # Impstation: Random Announcer System
duration: null # the rule has to last the whole round not 1 second
occursDuringRoundEnd: false
- type: PrecognitionResult # DeltaV - Precogniton