-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Combat hypospray #2701
base: master
Are you sure you want to change the base?
WIP: Combat hypospray #2701
Conversation
RSI Diff Bot; head commit 42c331a merging into adb9a55 Resources/Textures/_DV/Objects/Specific/Medical/combathypo.rsi
|
e15ca6b
to
f5c299d
Compare
f5c299d
to
5878925
Compare
5878925
to
42c331a
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Initial impression is that direction likes this! Some feedback we have is that it should be single shot only with manual reloads, and the cartridges themselves should be fairly large- perhaps 1x2. |
Can you expand on what you mean by single shot with only manual reloads? A full 30u in one large dose or that it might take a bottle of 30u and make 6 x 5u doses? |
WIPWIPWIPWIPWIPWIWPIPWIP
TODO:
About the PR
Added a new type of hypospray designed for Corpsman and Parameds to help them in fire fights or intense situations where having someone still for a syringe injection is too much.
The combat hypospray works with cartridges that are inserted into it to "fill" it with a given solution. These cartridges are hot swappable and contain 30u of solution. Cartridges are not drinkable, drawable, or refillable so they are used they are thrown away or recycled into glass.
Cartridges are constructed from a cartridge fabricator which takes any chemistry bottle as an input, once the bottle interacts with the machine (much like the seed extractor) then a cartridge will be produced and placed in the users hands if possible. A check is performed to see whether this bottle contains valid "medicinal" reagents and is rejected with a message if it does.
Valid reagents are controlled by the
groupWhitelist
andreagentWhitelists
fields, the former means you can set things like "All medicines" and the latter means you can add narcotics like ephedrine. This behaviour is overridable by the emag, a fabricator that is emagged will let you put anything into a cartridge.Why / Balance
Corpsman, in my eyes at least, are the combat medic attached to the security force to enable them to keep fighting for long periods without have to go all the way back to med and/or lose ground in a fight against an antag. Having them wait for a syringe while being shot at is not viable.
Parameds are less reliant on this but can still provide a useful combat medical role, as well as a fast response unit to try and get someone back on their feet (if they have any after shitmed) and get to the medical bay asap.
Technical details
Inspired by/taken from: Goob-Station/Goob-Station#953
Ideally we'd re-use as much of the upstream code as possible, so having the cartridges refill the hypospray directly (without letting the hypospray ever draw) is useful.
Media
Requirements
Breaking changes
Changelog