[Port] Markings support shaders #2767
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
S: Needs Review
size/L
|
RSI Diff Bot; head commit 6893aa4 merging into 71932a3 Resources/Textures/_Impstation/Mobs/Customization/animatedmarkings.rsi
Resources/Textures/_Impstation/Mobs/Customization/arachnid.rsi
Resources/Textures/_Impstation/Mobs/Customization/diona.rsi
Resources/Textures/_Impstation/Mobs/Customization/moth.rsi
Resources/Textures/_Impstation/Mobs/Customization/slime_parts.rsi
Resources/Textures/_Impstation/Mobs/Customization/vox.rsi
|
Lyndomen
approved these changes
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
This is primarily a port of impstation/imp-station-14#842, mostly to fix a bug I noticed with a harpy marking added in #1641 but I also decided to port impstation/imp-station-14#833 and parts of impstation/imp-station-14#1181 so that more species have access to the new marking shader feature
I'll admit, I'm not quite sure how to organize what I did to get the bionic harpy wing marking functioning w/r/t file structure. Applying a shader to a marking is an all-or-nothing situation, so I split the marking in two with the highlights now being unshaded. Would like input there
Why / Balance
Bugfix + purely cosmetic/flavor change. If anything, a player that opts into these markings is tactically disadvantaged because now they are visible in low light
Technical details
Alters HumanoidAppearanceSystem and MarkingPrototype to accept shaders, and prototypes.go because. um. i actually don't know but the original PR did this. Splits HarpyWingBionic into two markings so that the lights are unshaded as initially intended; adds 10 new markings (2 slime, 2 arachnid, 2 moth, 3 diona, 1 vox) that utilize unshaded.
Media
markings.demo.mp4
Requirements
Breaking changes
Simple Bionic Wings (Whitescale) is now #FFFFFF by default and is missing the string of lights; characters using that marking need to add Simple Bionic Wings (Lights) from the Overlay tab
Changelog
🆑 widgetbeck, Sha-Seng, hivehum, crocodilecarousel