Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor felinid/chitinid item coughing #2790

Merged
merged 7 commits into from
Jan 23, 2025

Conversation

deltanedas
Copy link
Member

About the PR

refactored it fully:

  • both species use ItemCougherComponent to do the item cough action, with their species components doing only the special interactions
  • moved all felinid components to shared, most of its non-duplicate code is still in server though

also changed mouse eating to just automatically happen when you eat a mouse instead of funny action, an event for it exists now

Why / Balance

be felinid
eat mouse with verb
no hairball

Technical details

the species systems use _cougher.EnableAction and handle ItemCoughedUpEvent to do their special logic its not longer shitcode

Media

eating mouse restores the charge for felinid
08:31:29
08:31:36

still cant purge by default
08:32:06

still can purge after healing 30 radiation
08:33:33

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

  • FelinidComponent, HairballComponent moved to Content.Shared._DV.Abilities.Felinid
    fields of FelinidComponent no longer exist, it uses ItemCougher instead
  • CoughingUpHairballComponent replaced by CoughingUpItemComponent
  • FelinidSystem is now in Content.Server._DV.Abilities.Felinid
  • ChitinidComponent no longer has item coughing fields

Changelog
🆑

  • tweak: Felinids no longer need to use an action to eat mice, just eating them normally works.

@deltanedas deltanedas requested review from a team as code owners January 23, 2025 20:41
@github-actions github-actions bot added S: Needs Review size/L 256-1023 lines Changes: YML Changes any yml files Changes: C# Changes any cs files Changes: Localization Changes any ftl files and removed size/L 256-1023 lines labels Jan 23, 2025
@github-actions github-actions bot added the size/L 256-1023 lines label Jan 23, 2025
@deltanedas deltanedas merged commit eda4147 into DeltaV-Station:master Jan 23, 2025
10 checks passed
@deltanedas deltanedas deleted the chitinid-ops branch January 23, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files S: Needs Review size/L 256-1023 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant