TerraGov Inspector #2791

Kr8art · 2025-01-24T11:44:15Z

About the PR

Adds the TerraGov Inspector as a ghost role antagonist.

Why / Balance

This is meant to be a fun RP heavy antagonist that's different from existing antagonists with no mechanical depth. You tie up station's attention and resources with your presence, inspect departments and interview the criminally underpaid NanoTrasen employees about their working conditions.

The inspector's outfit/id is also chameleon whitelisted to enable syndicate impostors that are less valid than the usual CentCom impostor.

The inspector currently uses the same shuttle as the syndicate recruiter and spawns with:

TerraGov Jumpsuit
TerraGov Headset with common and command channels
Two different TerraGov hats
Administration Glasses
TerraGov PDA with TerraGov pen and TerraGov ID (Basic + Command access)
TerraGov stamp
TerraGov clipboard
White gloves and leather shoes

Technical details

Adds a new Ghostrole that works pretty much identical to the Syndicate recruiter on a technical level
Adds a whole new set of TerraGov themed sprites

To Do:

There's still a few kinks I need to iron out:

Define playtime requirements/whitelist (IMPORTANT)
Fix profession in character window.
Make stamp objective greentextable.
ID card doesn't have the inspector's name.
Extend random appearance to all morphotypes, instead of just humans.

Media

Sprite showcase

Ghostrole/Shuttle

Objectives

Stamp

Requirements

I have tested all added content and changes.
I have added media to this PR or it does not require an ingame showcase.

Breaking changes

My sanity.

Changelog
🆑

add: The TerraGov Inspector is now available as a new ghost role! Strike fear into the heart of department heads as you look for healthcode violations and enforce workplace safety protocols. Credits to JustAnOrange for doing most of the shiny new sprites!

github-actions · 2025-01-24T11:44:28Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2025-01-24T11:44:50Z

RSI Diff Bot; head commit 89ca87c merging into 069dc1e
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Clothing/Ears/Headsets/terragov.rsi

State	Old	New	Status
alt-equipped-EARS			Added
equipped-EARS			Added
icon			Added
icon_alt			Added

Resources/Textures/DeltaV/Clothing/Head/Hats/beret_terragov.rsi

State	Old	New	Status
equipped-HELMET-hamster			Added
equipped-HELMET			Added
icon			Added

Resources/Textures/DeltaV/Clothing/Head/Hats/terracap.rsi

State	Old	New	Status
equipped-HELMET-hamster			Added
equipped-HELMET			Added
icon			Added

Resources/Textures/DeltaV/Clothing/Uniforms/Jumpsuit/terragov.rsi

State	Old	New	Status
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/DeltaV/Interface/Misc/job_icons.rsi

State	Old	New	Status
TerraGov			Added

Resources/Textures/DeltaV/Markers/jobs.rsi

State	Old	New	Status
inspector			Added

Resources/Textures/DeltaV/Objects/Devices/pda.rsi

State	Old	New	Status
pda-terragov			Added

Resources/Textures/DeltaV/Objects/Misc/stamps.rsi

State	Old	New	Status
stamp-terragov			Added

Resources/Textures/DeltaV/Objects/Misc/terragov_clipboard.rsi

State	Old	New	Status
clipboard			Added
clipboard_over			Added
clipboard_paper			Added
clipboard_pen			Added
equipped-BELT			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/Objects/Misc/bureaucracy.rsi

State	Old	New	Status
paper_stamp-terragov			Added

Resources/Textures/Objects/Misc/id_cards.rsi

State	Old	New	Status
idterragov			Added

Resources/Textures/Objects/Misc/pens.rsi

State	Old	New	Status
terragov_pen			Added

Bonktrauma · 2025-01-24T12:38:01Z

Honestly they should be focusing on making sure the station is upholding the law

Avalon-Proto · 2025-01-24T12:49:35Z

Honestly they should be focusing on making sure the station is upholding the law

Are laws concerning worker safety and workplace sanitation non existent? :blunt:

Smugman · 2025-01-24T12:58:33Z

I really like this concept!
An Idea, they should perhaps spawn with a "Inspection Warrant" or something like that so the Station is unable to refuse them entry, or maybe just an Announcement saying that "An Inspector from TerraGov bearing an Official Comission will be arriving soon."

Also, TerraGov handyflag, one day...

Are laws concerning worker safety and workplace sanitation non existent? :blunt:
Yes :Godo:

Kr8art · 2025-01-24T13:07:47Z

I really like this concept! An Idea, they should perhaps spawn with a "Inspection Warrant" or something like that so the Station is unable to refuse them entry, or maybe just an Announcement saying that "An Inspector from TerraGov bearing an Official Comission will be arriving soon."

Personally, I'd prefer to avoid adding these things to make it easier for syndicate agents to impersonate an inspector.

A legitimate inspector can still write their own inspection warrant on the shuttle before they arrive to the station and stamp it with their stamp. Since they have command access in their ID, they can also walk into the bridge and use the announcement console to make their presence known.

Smugman · 2025-01-24T14:35:20Z

Personally, I'd prefer to avoid adding these things to make it easier for syndicate agents to impersonate an inspector.

A legitimate inspector can still write their own inspection warrant on the shuttle before they arrive to the station and stamp it with their stamp. Since they have command access in their ID, they can also walk into the bridge and use the announcement console to make their presence known.

Fair point. I dont think even the most ornery captain would think "Yes, I can tell the man who centcom has given command access to leave."

CentCom ops get insta-"valided", so this would be a nice middle ground.

deltanedas · 2025-01-24T21:26:22Z

there are no space workspace safety laws so this should be a super lawyer making sure all space law violations are correctly punished imo

ThataKat · 2025-01-25T17:09:41Z

Direction is looking it over. This one has big implications so it'll probably be several days, but we'll pop back in whenever we have relevant feedback.

Smugman · 2025-01-27T09:22:59Z

Also, TerraGov handyflag, one day...

TerraGov handyflag, NOW!

Spirtes very much not final, i cant get the icon quiiite right...

Lyndomen

Hi! I personally really love this concept, and think the contents bring a lot of options to our Curator team with TerraGov flavored events.

I commented a few issues, the common theme is effectively that we're not sure how this fits as an antagonist, and we're also worried it becomes routine and expected- similar to how the traveling chef is ignored in 90% of cases. We're curious if you have any ideas in how they might be driven to interact further with the station?

Some ideas we've had is a loose re framing of this to Internal Affairs, with objectives to secretly kidnap and interview crewmembers, or acting more as a vigilante to hunt down a specific Fugitive.

I'd be curious to hear your thoughts, and look forward to seeing this evolve!

Resources/Locale/en-US/deltav/game-ticking/game-rules/rule-inspector.ftl

Resources/Locale/en-US/deltav/ghost/roles/ghost-role-component.ftl

Resources/Locale/en-US/deltav/objectives/conditions/inspector.ftl

Radezolid

Ensure four space indentation on your JSON files, leave the upstream ones with their current indentation.

Resources/Prototypes/DeltaV/Entities/Markers/Spawners/ghost_roles.yml

Radezolid · 2025-01-28T14:55:12Z

Resources/Prototypes/DeltaV/Entities/Objects/Devices/pda.yml

+  - type: CartridgeLoader
+    preinstalled:
+    - CrewManifestCartridge
+    - NotekeeperCartridge
+    - NewsReaderCartridge


This is redundant, you inherit these from the BasePDA.

Radezolid · 2025-01-28T15:19:24Z

Resources/Prototypes/DeltaV/Entities/Objects/Misc/identification_cards.yml

+  - type: Item
+    heldPrefix: default


This is redundant due to the IDCardStandard parenting.

Resources/Prototypes/DeltaV/Roles/Antags/inspector.yml

Resources/Prototypes/DeltaV/Roles/Jobs/Terragov/inspector.yml

Radezolid · 2025-01-28T15:46:58Z

Resources/Prototypes/DeltaV/Roles/Jobs/Terragov/inspector.yml

+      - type: CommandStaff
+  - !type:AddComponentSpecial
+    components:
+    - type: PsionicBonusChance #Nyano - Summary: makes it more likely to become psionic.


Remove the Nyano comment.

Radezolid · 2025-01-28T15:50:33Z

Resources/Prototypes/DeltaV/StatusIcon/job.yml

+  parent: JobIcon
+  id: JobIconTerraGov
+  icon:
+    sprite: /Textures/DeltaV/Interface/Misc/job_icons.rsi


The /Textures/ is extra.

Radezolid · 2025-01-28T15:51:52Z

Resources/Prototypes/Entities/Objects/Misc/paper.yml

+## DeltaV - TerraGov Clipboard
+- type: entity
+  id: BoxFolderTerraGovClipboard
+  parent: BoxFolderClipboard
+  name: TerraGov clipboard
+  description: A luxurious clipboard upholstered with blue velvet. Often seen carried by TerraGov officials, seldom seen actually used.
+  components:
+  - type: Sprite
+    sprite: DeltaV/Objects/Misc/terragov_clipboard.rsi
+    layers:
+    - state: clipboard
+    - state: clipboard_paper
+      map: ["clipboard_paper"]
+      visible: false
+    - state: clipboard_pen
+      map: ["clipboard_pen"]
+      visible: false
+    - state: clipboard_over
+  - type: Item
+    sprite: DeltaV/Objects/Misc/terragov_clipboard.rsi
+  - type: Clothing
+    sprite: DeltaV/Objects/Misc/terragov_clipboard.rsi
+


Move this to the _DV namespace.

Radezolid · 2025-01-28T15:52:33Z

Resources/Prototypes/Entities/Objects/Misc/pen.yml

+- type: entity
+  name: terragov pen
+  parent: Pen
+  id: TerraGovPen
+  description: A fancy and bright blue pen that marks you as official TerraGov paper-pusher.
+  components:
+  - type: Sprite
+    state: terragov_pen
+  - type: Item
+    heldPrefix: terragov_pen
+


Move this to the _DV namespace.

Radezolid · 2025-01-28T15:59:11Z

Just in case, here is an example of a correct JSON indentation:

Delta-v/Resources/Textures/_DV/Clothing/Uniforms/Jumpsuit/security_alt.rsi/meta.json

Lines 1 to 30 in 47749d9

    
           { 
        
               "version": 1, 
        
               "license": "CC0-1.0", 
        
               "copyright": "Original work by TJohnson.", 
        
               "size": { 
        
                   "x": 32, 
        
                   "y": 32 
        
               }, 
        
               "states": [ 
        
                   { 
        
                       "name": "icon" 
        
                   }, 
        
                   { 
        
                       "name": "equipped-INNERCLOTHING", 
        
                       "directions": 4 
        
                   }, 
        
                   { 
        
                       "name": "inhand-left", 
        
                       "directions": 4 
        
                   }, 
        
                   { 
        
                       "name": "inhand-right", 
        
                       "directions": 4 
        
                   }, 
        
                   { 
        
                       "name": "rolled-equipped-INNERCLOTHING", 
        
                       "directions": 4 
        
                   } 
        
               ] 
        
           }

ThataKat · 2025-02-01T03:22:19Z

Direction update, we're still workshopping this with the author. Discussion is in a thread in the contrib channel on Discord

Kr8art · 2025-02-02T12:26:55Z

Since a direction doesn't want a TerraGov themed inspector any longer, I'll be removing all role related changes and make this PR purely for the sprites so they can be used for events (and maybe available in an emag'd uniform printer).

I am dismissing all the feedback regarding the files that touch upon the role, since it is not relevant any longer.

TerraGov Inspector

89ca87c

Kr8art requested review from a team as code owners January 24, 2025 11:44

github-actions bot added S: Needs Review size/L 256-1023 lines S: Merge Conflict Fix your PR! labels Jan 24, 2025

github-actions bot added Changes: YML Changes any yml files Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi labels Jan 24, 2025

Lyndomen requested changes Jan 27, 2025

View reviewed changes

Resources/Locale/en-US/deltav/game-ticking/game-rules/rule-inspector.ftl Show resolved Hide resolved

Resources/Locale/en-US/deltav/ghost/roles/ghost-role-component.ftl Show resolved Hide resolved

Resources/Locale/en-US/deltav/objectives/conditions/inspector.ftl Show resolved Hide resolved

Radezolid suggested changes Jan 28, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TerraGov Inspector #2791

TerraGov Inspector #2791

Kr8art commented Jan 24, 2025 •

edited

Loading

github-actions bot commented Jan 24, 2025

github-actions bot commented Jan 24, 2025

Bonktrauma commented Jan 24, 2025

Avalon-Proto commented Jan 24, 2025

Smugman commented Jan 24, 2025

Kr8art commented Jan 24, 2025

Smugman commented Jan 24, 2025

deltanedas commented Jan 24, 2025

ThataKat commented Jan 25, 2025

Smugman commented Jan 27, 2025 •

edited

Loading

Lyndomen left a comment

Radezolid left a comment

Radezolid Jan 28, 2025

Radezolid Jan 28, 2025

Radezolid Jan 28, 2025

Radezolid Jan 28, 2025

Radezolid Jan 28, 2025

Radezolid Jan 28, 2025

Radezolid commented Jan 28, 2025

ThataKat commented Feb 1, 2025

Kr8art commented Feb 2, 2025 •

edited

Loading

TerraGov Inspector #2791

Are you sure you want to change the base?

TerraGov Inspector #2791

Conversation

Kr8art commented Jan 24, 2025 • edited Loading

About the PR

Why / Balance

Technical details

To Do:

Media

Requirements

Breaking changes

github-actions bot commented Jan 24, 2025

github-actions bot commented Jan 24, 2025

Bonktrauma commented Jan 24, 2025

Avalon-Proto commented Jan 24, 2025

Smugman commented Jan 24, 2025

Kr8art commented Jan 24, 2025

Smugman commented Jan 24, 2025

deltanedas commented Jan 24, 2025

ThataKat commented Jan 25, 2025

Smugman commented Jan 27, 2025 • edited Loading

Lyndomen left a comment

Choose a reason for hiding this comment

Radezolid left a comment

Choose a reason for hiding this comment

Radezolid Jan 28, 2025

Choose a reason for hiding this comment

Radezolid Jan 28, 2025

Choose a reason for hiding this comment

Radezolid Jan 28, 2025

Choose a reason for hiding this comment

Radezolid Jan 28, 2025

Choose a reason for hiding this comment

Radezolid Jan 28, 2025

Choose a reason for hiding this comment

Radezolid Jan 28, 2025

Choose a reason for hiding this comment

Radezolid commented Jan 28, 2025

ThataKat commented Feb 1, 2025

Kr8art commented Feb 2, 2025 • edited Loading

Kr8art commented Jan 24, 2025 •

edited

Loading

Smugman commented Jan 27, 2025 •

edited

Loading

Kr8art commented Feb 2, 2025 •

edited

Loading