-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make crew monitors beep when someone dies / crits #2930
Make crew monitors beep when someone dies / crits #2930
Conversation
f05efd2
to
278d1da
Compare
Does this check if the crew monitoring server is powered as well? |
Also direction review will be around 24 hours |
Yes, this checks power from both from a power cell or station power (for the machine version). Alerting does not use power, though. EDIT: I have misunderstood the original question. My changes do not directly check the server, but I assume if it is down the monitors will not receive packets that would trigger my logic |
Content.Server/Medical/CrewMonitoring/CrewMonitoringConsoleComponent.cs
Outdated
Show resolved
Hide resolved
Content.Server/Medical/CrewMonitoring/CrewMonitoringConsoleComponent.cs
Outdated
Show resolved
Hide resolved
Requested changes are completed and tested. |
Content.Server/Medical/CrewMonitoring/CrewMonitoringConsoleComponent.cs
Outdated
Show resolved
Hide resolved
Content.Server/Medical/CrewMonitoring/CrewMonitoringConsoleSystem.cs
Outdated
Show resolved
Hide resolved
Content.Server/Medical/CrewMonitoring/CrewMonitoringConsoleSystem.cs
Outdated
Show resolved
Hide resolved
To address your questions:
|
true, no rp allowed for parameds |
Direction approved. |
Requested changes are made and tested. Actually using future timestamps now for the cooldown. |
The toggle is already implemented though! Just remove battery from handheld or unanchor the console. :blunt: |
Also that. |
Content.Server/Medical/CrewMonitoring/CrewMonitoringConsoleComponent.cs
Outdated
Show resolved
Hide resolved
Okay so I have 1 SLIGHT annoyance with this. Thanks to the fact Aghosts have the crew monitor interface, its gets QUITE annoying hearing it randomly beep at you in the middle of handling an Ahelp |
Ah, did not know that. That sure sounds like it's QUITE annoying. I'll make a pr with a fix for that in a few days. |
* Make the crew monitors beep when someone dies or crits * Cleanup * Fix a comment that was not updated earlier. Signed-off-by: Quanteey <[email protected]> * Switch frame time tracking to using timespans * use timestamps of next alert instead of frame time tracking * Fix outdated docs --------- Signed-off-by: Quanteey <[email protected]>
About the PR
This PR makes the handheld crew monitor and the crew monitoring console play a beeping sound in a small radius whenever a crew member with appropriate sensors enabled dies. This change does not affect the spy and syndicate crew monitors, and the alert behavior can be enabled / disabled in the YAML prototypes.
Alerts are issued whenever a crew member goes into critical / dead state, and no further alerts will be issued for that specific crew member until they get out of dead / critical state. A 15 second cooldown is in place between two alerts to reduce spam. Alerts require the monitor to be powered.
Why / Balance
Paramedics are expected to respond immediately when someone goes critical / dies. However, there is currently no system in place to actively alert them when that happens. This leaves paramedics either staring at the monitor for pretty much 2 hours, which is not optimal gameplay-wise, or checking every minute or two, which is not very efficient.
This change solves this issue altogether, allowing them to do other activities during downtime without having to worry about missing someone dying.
Technical details
Modified
CrewMonitoringConsoleComponent
to store a HashSet of crew members a given monitor has already alerted for, along with frame time tracking (for the cooldown, same implementation as the Morgue). Added 3 optional DataFields for enabling / disabling alerts, configuring cooldowns, and the sound.The main logic is in the
CrewMonitoringConsoleSystem
'sOnPacketReceived
, along a newUpdate
override for frame time tracking.The new audio file comes from Pixabay with a CC0 license.
Media
2025-02-08.16-34-51.mov
Requirements
Breaking changes
Changelog
🆑