Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old syndicate cyborg #856

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

FluffiestFloof
Copy link
Contributor

About the PR

Remove old half reimplemented and commented out syndicate cyborg since upstream added one to the uplink already that serves the same purpose.
Mostly a suggestion but since it's literally just comments.

It's commented out anyway
@DebugOk
Copy link
Contributor

DebugOk commented Feb 18, 2024

Thank you

@DebugOk DebugOk enabled auto-merge (squash) February 18, 2024 21:55
@DebugOk DebugOk merged commit fe94160 into DeltaV-Station:master Feb 18, 2024
12 checks passed
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 3, 2025
# Description
As was discussed on discord, quick swap is a feature that makes certain
things needlessly easy. You can instantly swap the magazine in a gun
without even paying attention to it, you can quickly swap cells in
IPCs/borgs, you can instantly swap the ID in your pda with that of
someone else without anyone noticing, et cetera. In my opinion, this is
unnecessary QOL that makes the game feel more bland and primitive.
Besides, it used to lead to odd and unwanted behavior, such as IPCs
being able to swap their own power cells.

In addition to that, certain entities do not support quick swap. For
instance, rechargers will stop working if you insert a power cell and
then quick-swap it before it finishes charging.

This PR makes quick swap disabled by default. It can still be re-enabled
by setting `ItemSlotsComponent.Slots.[ItemSlot].Swap = true` on
individual entities.

# Changelog
:cl:
- remove: Quick swap has been disabled for most item slots. This
primarily means you will have to eject power cells/magazines from
items/weapons/borgs before replacing them with different ones.
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants