German Accent #945
German Accent #945
Conversation
github-actions
bot
added
Changes: C#
Signed-off-by: Danger Revolution! <[email protected]>
|
Okay, so. I would really like to apologize for this. I had never actually read the code for Accent traits, and had mistakenly assumed that the Accent traits would have been coded in a sane and reasonable way. In the case of a German accent, it's most easily done by using exactly 7 lines of String.Replace. You can pretty easily replace Line 24 with about 6 or 7 lines of this specific Dotnet 8.0 function. Luckily Microsoft's own website for Dotnet 8.0 comes with very helpful code examples for how to use the function. In this context, the Variable "message" is a string that you can put directly into String.Replace. https://learn.microsoft.com/en-us/dotnet/api/system.string.replace?view=net-8.0 Doing so will make the entire combined 800 lines of accent word replacements obsolete. Which if you did so, could cut this PR down from +896 to only +44 to +50 lines. One more thing, please don't rely on AI to make this translation, in this context it is a genuinely awful idea as it makes the speaker sound like a stereotype of someone with a German accent, which can be seen as fairly offensive. I've went and found an article that describes specific sound shifting techniques for how to portray a realistic German accent, and conveniently enough most of it is done by replacing sounds(letters) with other sounds(letters). This is something that String.Replace can do quite handily. https://www.backstage.com/magazine/article/how-to-do-a-german-accent-75917/ I'm going to go ahead and draft this PR until these kind of changes are made. |
| { | ||
| var msg = message; | ||
|
|
||
| msg = _replacement.ApplyReplacements(msg, "german"); |
There was a problem hiding this comment.
This line specifically can be replaced with a couple uses of String.Replace, which would make the Replacements unnecessary entirely.
There was a problem hiding this comment.
This how accent replacements should be done
AI was not used to generate the replacement list, it was used to convert the Yogstation json to ftl. |
My mistake, however it well.. I'll be honest the SS13 forks aren't exactly known for having sane traits. I very distinctly remember Yoggstation having a Tourettes trait that was literally the worst possible portrayal of Tourettes. I wouldn't consider porting their code to generally be a good idea, as much of it is in extremely poor taste. |
|
I'm making the decision that no more accents should be added, and I believe this to be too stereotypical. I dislike these sorts of accents in general and think they're of poor taste. |
# Description This PR adds a few new recipes to Quick Construction (accessed by pressing Z on commonly used construction materials/items, such as rods, glass, steel, plasma, etc etc). Along with simple nesting for grouping items up under categories, akin to how the RCD works. Which allows engineers to massively speed up pipe laying work, disposal rebuilding, setting up the supermatter, etc etc. First time doing UI code, apologies for the shitcode in advance :godo: --- <details><summary><h1>Media</h1></summary> <p> https://github.com/user-attachments/assets/9d540d7f-7e4f-4a43-874d-5ea069011a37 </p> </details> --- # Considerations Is this powergamey? Probably. Is it fucking awesome? Hell yeah. Some servers might question the fact that everyone can build stuff this fast now that they dont have to deal too much with the construction menu for the most common things... And might want to lock it behind traits or given as a job freebie, like CPR for doctors. Other servers might appreciate it if they are looking for more action to happen over the round, and giving everyone the ability to deal with breaches and repairs quicker is probably a step into that direction. I'll be observing for feedback and adjust accordingly. It also shouldn't invalidate any eventual RPDs, or other devices of the kind since this is just a shortcut for construction, you still require materials and a doafter for most of them. --- # Changelog :cl: Mocho - add: Added a lot of recipes to the quick construction menus. Give it a shot by pressing Z with different construction materials in your hand! --------- Signed-off-by: gluesniffler <[email protected]> Co-authored-by: VMSolidus <[email protected]>
About the PR
This accent is a direct 1:1 from YogStation (linked in the .ftl), with minor tweaks. For future proofing and edge-case roleplay scenarios I've kept in references to Antags that aren't here in Station 14.
Gonna be honest, I haven't read the entire list yet.
This PR mostly relied on Bing AI to write this up for me. I'm not insane or a masochist so I didn't write up 400 word combinations for the accent and got Bing to do it for me.
Why / Balance
I've seen a few people over the last week roleplaying Germans, with the accent and all. Thought it'd be cool to make them an accent.
Technical details
1:1 copy of the Scottish accent trait, just for German.
Media
Please note: I'm not German, this is a north German-styled accent and I would appreciate some feedback for words that could be better etc etc.
Changelog DangerRevolution
🆑