Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lunchbox size fix #998

Merged

Conversation

FluffiestFloof
Copy link
Contributor

@FluffiestFloof FluffiestFloof commented Mar 23, 2024

Lunchbox now takes 8 space and only has 8 space of storage.

Breaking changes

Changelog

🆑

  • tweak: Changed lunchbox size.

@github-actions github-actions bot added the Changes: YML Changes any yml files label Mar 23, 2024
@IamVelcroboy
Copy link
Member

So, I think a better way to handle this would be to make the size of the box = the size of internal storage. If the standard small/normal/large sizes don't work, you can set a custom size in the Item/shape node. Maybe that with a slight reduction to how much it holds?

@FluffiestFloof
Copy link
Contributor Author

Sure. I will make the box only 4 slots then I suppose

@IamVelcroboy
Copy link
Member

Sure. I will make the box only 4 slots then I suppose

No I mean, make the space the box takes up in another inventory bigger like 2 x8 or something. And then trim the extra tile in the last row.

@IamVelcroboy
Copy link
Member

Look at the cigar case for an example. It uses the AaBb system

@FluffiestFloof
Copy link
Contributor Author

done it takes 8 space and only has 8 space

@FluffiestFloof FluffiestFloof changed the title Lunchbox only takes food Lunchbox size fix Mar 23, 2024
@rosieposieeee
Copy link
Contributor

Personally I think 4-4 would be better than 8-8, if only because I can't imagine anyone carrying a lunchbox if it were that big.

@IamVelcroboy
Copy link
Member

Personally I think 4-4 would be better than 8-8, if only because I can't imagine anyone carrying a lunchbox if it were that big.

If we make it smaller than 8, we'll have to start editing the inventory too. Otherwise, it will overfill

@DangerRevolution
Copy link
Contributor

Size fix > Food fix as Food requires alotta tags & upstreaming + the intention was to also allow people to carry contraband. 4x4 is a nice size for a lunchbox anyways.

@IamVelcroboy
Copy link
Member

How about 2x3?

@DangerRevolution
Copy link
Contributor

How about 2x3?

What size is the toolbox in an inventory?

@IamVelcroboy
Copy link
Member

Toolbox is made so it doesn't fit in an inventory.. Other than bluespace maybe

@IamVelcroboy
Copy link
Member

Closest comparison, I can think of, is cigar case which is 2x3

Apparently people don't want empty orange cartons???
@FluffiestFloof
Copy link
Contributor Author

Fine, I guess I'm creating new juice boxes because the orange carton is 2x2 for some reason

@DangerRevolution
Copy link
Contributor

I can do this at another time if you don't, but fixing the probabilities to be true probabilities rather than skewing towards healthy food would be nice. Station 14's "storageFill" system probabilities use the "Sequential" model rather than Simultaenous. The game rolls whether it puts the first item in the list, then the next, then the next, then the next. When using "or" probabilities this means that items that roll first; are more likely to be put in than items that roll second.

image

Item attached is related. That's how item picks work, I guess.

@github-actions github-actions bot added the Changes: Sprite Changes any png or json in an rsi label Mar 23, 2024
Copy link
Contributor

github-actions bot commented Mar 23, 2024

RSI Diff Bot; head commit c6666e0 merging into 82d700f
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Objects/Consumable/Drinks/juiceboxapple.rsi

State Old New Status
icon Added
icon_open Added

Resources/Textures/DeltaV/Objects/Consumable/Drinks/juiceboxchocolate.rsi

State Old New Status
icon Added
icon_open Added

Resources/Textures/DeltaV/Objects/Consumable/Drinks/juiceboxgrape.rsi

State Old New Status
icon Added
icon_open Added

Resources/Textures/DeltaV/Objects/Consumable/Drinks/juiceboxorange.rsi

State Old New Status
icon Added
icon_open Added

Resources/Textures/DeltaV/Objects/Consumable/Drinks/juiceboxpineapple.rsi

State Old New Status
icon Added
icon_open Added

Edit: diff updated after c6666e0

@FluffiestFloof FluffiestFloof force-pushed the lunchboxforfoodnotfortools branch from 88f3744 to 324ee6b Compare March 23, 2024 22:39
@FluffiestFloof
Copy link
Contributor Author

FluffiestFloof commented Mar 23, 2024

How about 2x3?

6 slots could be doable if we ditch the note because biggest item for each item fill is 2 slots.
Except if we want to have it with more slots than space it takes, which is a big thonk personally. But it's not like I play :trollface:

@IamVelcroboy
Copy link
Member

Nah, Is good how it is. Juice boxes look great!

@IamVelcroboy IamVelcroboy merged commit c278c3f into DeltaV-Station:master Mar 25, 2024
12 checks passed
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 3, 2025
# Description

This ports WWhiteDreamProject/wwdpublic#56
The new Respawn System is one that allows players to return themselves
to the lobby after a configurable delay, while also requiring that they
respawn as a different character upon returning.

# TODO

- [x] Finish the usual cleanup

# Changelog

:cl:
- add: Ported a Respawn System. This system allows players to return
themselves to the lobby, while also requiring that if they re-enter the
round, that they must do so on a different character.

---------

Co-authored-by: Spatison <[email protected]>
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants