-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moved from conda/flit to pip #149
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I did not realise we were fully pip installable :)
Maybe good to update the update the installation with the two flavors then? 1 fully from pip and one with part conda / part pip).
Would be nice to be on conda-forge also at some point but let's keep this for later.
You mean updating the docs right? In installation.rst it is already a pip install actually. There is all this stuff about mamba and libmamba that is a bit distracting, but in the end it is |
Yes updating the docs! Well indeed if it is pip installable you would not need to add the hydromt when the envrionment is created. For the conda example, I think they still need to install pip when they create their environment else hydromt-delft3dfm may end up being installed in their base environment:
|
Issue addressed
Fixes #136
Explanation
The installation of the conda environment on github takes 5-10 minutes (depending on the season, the temperature, or something else). This is way faster with pip (2.5 minutes) and this also drops the flit dependency. Furthermore, this way we can also test on python 3.12 (all tests pass). In the future it might be better to move to pixi (just like everyone else) and use lockfiles and such, but I think this is a useful inbetween solution.
I would also prefer to delete
envs/hydromt-delft3dfm.yml
, but it is at the moment required by.github/workflows/docs.yml
(which also requires flit actually).Checklist
main