Issue #1248 Write svat_groundwater to file and update the tests #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1248
Description
This PR fixes Issue #1248 by removing the
svat_groundwaterfrom the _to_fill variable. For now the source svat == target svat.In addition the
max_abstraction_groundwatershould now contains the subunit coordinate. The current implementation assigned the abstraction to all stacked subunits. This is not desirable in case the second svat represents the urban area for example. Now its up to the user to define irrigation at the subunit level.Checklist
Issue #nr, e.g.Issue #737