Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach + EntityTag beginnings #6

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
c4bdedd
funny draft
acikek Oct 19, 2022
b9b1a0a
g
acikek Oct 19, 2022
6e53820
Merge branch 'main' into attach
tal5 Dec 3, 2022
5a90ace
`EntityTag` to `objects` , update `ClientTagBase`
tal5 Dec 4, 2022
0ed8bc1
Merge branch 'main' into attach
tal5 Dec 4, 2022
047a355
`EntityTag` cleanup and fixes
tal5 Dec 4, 2022
ec01f1f
Fix `AttachCommand` param
tal5 Dec 4, 2022
ceee245
Cleanup imports
tal5 Dec 5, 2022
b35468c
`client.self_entity`
tal5 Dec 5, 2022
f88cc7f
Fixup `attach` command
tal5 Dec 5, 2022
4927417
Merge branch 'main' into attach
acikek Jan 6, 2023
3280c05
actually make rendering work well i think
acikek Jan 6, 2023
abdf37b
Fix repository order
tal5 Jan 7, 2023
4d44a6c
Implement `debuggable` in `EntityTag`
tal5 Jan 9, 2023
a21f4bd
Revert "Implement `debuggable` in `EntityTag`"
tal5 Jan 9, 2023
417cb32
Implement `debuggable` in `EntityTag`
tal5 Jan 9, 2023
c9e741f
Fix attaching entities to other entities
tal5 Jan 9, 2023
055bf15
Attempted lighting improvment
tal5 Jan 9, 2023
29ba868
Merge branch 'main' into attach
tal5 Jan 9, 2023
865da19
Remove leftover
tal5 Jan 9, 2023
3ff18f0
Merge branch 'main' into attach
tal5 Jan 10, 2023
575cc53
Fix lighting issues with attach
tal5 Jan 13, 2023
9c477f0
Supress unchecked cast warning. remove old code
tal5 Jan 13, 2023
40b7f24
Minor `EntityTag` cleanups
tal5 Jan 13, 2023
165eb5f
experimental args for attach
acikek Jan 13, 2023
8f02565
Register `attached` feature renderer using API
tal5 Jan 13, 2023
d98e620
Prevent rotation for attached entities
tal5 Jan 13, 2023
7894a32
Supress warning in previous commit
tal5 Jan 13, 2023
03ceb06
Improve `EntityTag#debuggable`
tal5 Jan 15, 2023
feaaa97
Implement `client.flag` tags
tal5 Jan 15, 2023
eadfbeb
Merge branch 'main' into attach
tal5 Jan 15, 2023
e6813e7
Merge branch 'main' into attach
tal5 Jan 15, 2023
cd40ac3
Merge branch 'main' into attach
tal5 Feb 5, 2023
cb68791
Remove old code
tal5 Feb 5, 2023
65ebf1a
Replace Tabs
tal5 Feb 5, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ archivesBaseName = project.archives_base_name
version = project.version
group = project.maven_group

loom {
accessWidenerPath = file("src/main/resources/clientizen.accesswidener")
}

repositories {
mavenCentral()
maven {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
package com.denizenscript.clientizen.mixin.render;

import com.denizenscript.clientizen.scripts.commands.AttachCommand;
import net.minecraft.client.render.Frustum;
import net.minecraft.client.render.entity.EntityRenderDispatcher;
import net.minecraft.entity.Entity;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfoReturnable;

@Mixin(EntityRenderDispatcher.class)
public class EntityRenderDispatcherMixin {

/*@Inject(method = "shouldRender", at = @At("HEAD"), cancellable = true)
private static <E extends Entity> void clientizen$cancelRenderIfAttached(
E entity, Frustum frustum, double x, double y, double z, CallbackInfoReturnable<Boolean> cir) {
if (AttachCommand.attachedEntities.containsKey(entity.getUuid())) {
cir.setReturnValue(false);
}
}*/
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
package com.denizenscript.clientizen.mixin.render;

import com.denizenscript.clientizen.scripts.commands.AttachCommand;
import net.minecraft.client.render.entity.EntityRenderer;
import net.minecraft.entity.Entity;
import net.minecraft.util.math.Vec3d;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfoReturnable;

@Mixin(EntityRenderer.class)
public class EntityRendererMixin<T extends Entity> {

/*@Inject(method = "<init>", at = @At("TAIL"))
private void clientizen$addAttachFeatureRenderer(EntityRendererFactory.Context ctx, CallbackInfo ci) {
add
}*/

@Inject(method = "getPositionOffset", cancellable = true, at = @At("HEAD"))
private void clientizen$getAttachedOffset(T entity, float tickDelta, CallbackInfoReturnable<Vec3d> cir) {
if (AttachCommand.attachedEntities.containsKey(entity.getUuid())) {
cir.setReturnValue(AttachCommand.attachedEntities.get(entity.getUuid()).getEntity().getPos().subtract(entity.getPos()));
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
package com.denizenscript.clientizen.render;

import net.minecraft.client.render.VertexConsumerProvider;
import net.minecraft.client.render.entity.feature.FeatureRenderer;
import net.minecraft.client.render.entity.feature.FeatureRendererContext;
import net.minecraft.client.render.entity.model.EntityModel;
import net.minecraft.client.util.math.MatrixStack;
import net.minecraft.entity.Entity;

public class ClientizenAttachedEntityFeatureRenderer extends FeatureRenderer<Entity, EntityModel<Entity>> {

public ClientizenAttachedEntityFeatureRenderer(FeatureRendererContext<Entity, EntityModel<Entity>> context) {
super(context);
}

@Override
public void render(MatrixStack matrices, VertexConsumerProvider vertexConsumers, int light, Entity entity, float limbAngle, float limbDistance, float tickDelta, float animationProgress, float headYaw, float headPitch) {

}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
package com.denizenscript.clientizen.scripts.commands;

import com.denizenscript.clientizen.tags.EntityTag;
import com.denizenscript.denizencore.scripts.ScriptEntry;
import com.denizenscript.denizencore.scripts.commands.AbstractCommand;
import com.denizenscript.denizencore.scripts.commands.generator.ArgLinear;
import com.denizenscript.denizencore.scripts.commands.generator.ArgName;
import com.denizenscript.denizencore.scripts.commands.generator.ArgPrefixed;

import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.UUID;

public class AttachCommand extends AbstractCommand {

public static Map<UUID, EntityTag> attachedEntities = new HashMap<>();

public AttachCommand() {
setName("attach");
setSyntax("attach [<entity>|...] [to:<entity>] (cancel)");
setRequiredArguments(2, 2);
isProcedural = false;
autoCompile();
}

public static void autoExecute(ScriptEntry scriptEntry,
@ArgLinear @ArgName("entities") List<EntityTag> attachingEntities,
Copy link
Member

@tal5 tal5 Oct 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

List isn't a supported parameter type, should use ListTag & ListTag#filter

@ArgPrefixed @ArgName("to") EntityTag entity,
@ArgName("cancel") boolean cancel) {
for (EntityTag attachingEntity : attachingEntities) {
if (cancel) {
attachedEntities.remove(attachingEntity.uuid);
}
else {
attachedEntities.put(attachingEntity.uuid, entity);
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@
public class ClientizenCommandRegistry {

public static void registerCommands() {
registerCommand(NarrateCommand.class);
registerCommand(AttachCommand.class);
registerCommand(GuiCommand.class);
registerCommand(NarrateCommand.class);
registerCommand(ServerEventCommand.class);
}

Expand Down
34 changes: 34 additions & 0 deletions src/main/java/com/denizenscript/clientizen/tags/ClientTagBase.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
package com.denizenscript.clientizen.tags;

import com.denizenscript.denizencore.objects.core.ListTag;
import com.denizenscript.denizencore.tags.PseudoObjectTagBase;
import com.denizenscript.denizencore.tags.TagManager;
import net.minecraft.client.MinecraftClient;
import net.minecraft.entity.Entity;

public class ClientTagBase extends PseudoObjectTagBase<ClientTagBase> {

public static ClientTagBase instance;

public static void register() {
instance = new ClientTagBase();
TagManager.registerStaticTagBaseHandler(ClientTagBase.class, "client", t -> instance);
}

@Override
public void registerTags() {

tagProcessor.registerTag(ListTag.class, "loaded_entities", (attribute, object) -> {
ListTag list = new ListTag();
for (Entity entity : MinecraftClient.getInstance().world.getEntities()) {
list.addObject(new EntityTag(entity));
}
return list;
});

tagProcessor.registerTag(EntityTag.class, "target", (attribute, object) -> {
System.out.println(MinecraftClient.getInstance().targetedEntity);
return new EntityTag(MinecraftClient.getInstance().targetedEntity);
});
}
}
Original file line number Diff line number Diff line change
@@ -1,8 +1,14 @@
package com.denizenscript.clientizen.tags;

import com.denizenscript.denizencore.objects.ObjectFetcher;
import com.denizenscript.denizencore.objects.ObjectType;

public class ClientizenTagRegistry {

public static void registerTagHandlers() {
public static ObjectType<EntityTag> TYPE_ENTITY;

public static void registerTagHandlers() {
ClientTagBase.register();
TYPE_ENTITY = ObjectFetcher.registerWithObjectFetcher(EntityTag.class, EntityTag.tagProcessor).setAsNOtherCode().generateBaseTag();
}
}
80 changes: 80 additions & 0 deletions src/main/java/com/denizenscript/clientizen/tags/EntityTag.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,80 @@
package com.denizenscript.clientizen.tags;

import com.denizenscript.denizencore.objects.Fetchable;
import com.denizenscript.denizencore.objects.ObjectTag;
import com.denizenscript.denizencore.objects.core.ElementTag;
import com.denizenscript.denizencore.tags.ObjectTagProcessor;
import com.denizenscript.denizencore.tags.TagContext;
import com.denizenscript.denizencore.utilities.debugging.Debug;
import net.minecraft.client.MinecraftClient;
import net.minecraft.entity.Entity;

import java.util.UUID;

public class EntityTag implements ObjectTag {

public UUID uuid;

public EntityTag(UUID uuid) {
this.uuid = uuid;
}

public EntityTag(Entity entity) {
this(entity.getUuid());
}

@Fetchable("e")
public static EntityTag valueOf(String string, TagContext tagContext) {
if (string == null) {
return null;
}
if (string.startsWith("e@")) {
return new EntityTag(UUID.fromString(string.substring(2)));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should check if it starts with e@ and substring before doing the UUID conversion, as just a UUID is valid as well

}
if (tagContext == null || tagContext.showErrors()) {
Debug.log("valueOf EntityTag returning null: " + string);
}
return null;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing matches method

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also missing getObjectAttribute implementation

public Entity getEntity() {
return MinecraftClient.getInstance().world.getEntityLookup().get(uuid);
}

public static ObjectTagProcessor<EntityTag> tagProcessor = new ObjectTagProcessor<>();

public static void registerTags() {

tagProcessor.registerTag(ElementTag.class, "entity_type", (attribute, object) -> {
return new ElementTag(object.getEntity().getType().getUntranslatedName(), true);
});
}

private String prefix = "Entity";

@Override
public String getPrefix() {
return prefix;
}

@Override
public boolean isUnique() {
return true;
}

@Override
public String identify() {
return "e@" + uuid;
}

@Override
public String identifySimple() {
return identify();
}

@Override
public ObjectTag setPrefix(String prefix) {
this.prefix = prefix;
return this;
}
}
3 changes: 3 additions & 0 deletions src/main/resources/clientizen.accesswidener
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
accessWidener v2 named

accessible method net/minecraft/client/world/ClientWorld getEntityLookup ()Lnet/minecraft/world/entity/EntityLookup;
4 changes: 3 additions & 1 deletion src/main/resources/clientizen.mixins.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@
"mixins": [],
"client": [
"KeyBindingMixin",
"MinecraftClientMixin"
"MinecraftClientMixin",
"render.EntityRenderDispatcherMixin",
"render.EntityRendererMixin"
],
"injectors": {
"defaultRequire": 1
Expand Down
1 change: 1 addition & 0 deletions src/main/resources/fabric.mod.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
"mixins": [
"clientizen.mixins.json"
],
"accessWidener": "clientizen.accesswidener",
"depends": {
"fabricloader": ">=0.14.9",
"fabric-api": "*",
Expand Down