Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix component hash policy evaluator #4306

Merged

Conversation

francislance
Copy link
Contributor

Description

This is for Component Hash policy condition only supports positive matches #4230

Addressed Issue

Component Hash policy condition only supports positive matches #4230

Additional Details

Local Testing Screenshots:

owasp-dt-hash-policy

Checklist

@francislance francislance force-pushed the fix-component-hash-policy-evaluator branch 2 times, most recently from 22101c9 to c4d5820 Compare October 25, 2024 08:35
@nscuro nscuro added the defect Something isn't working label Oct 26, 2024
@nscuro nscuro added this to the 4.13 milestone Oct 26, 2024
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @francislance! Could you please add a test for the IS_NOT operator?

@francislance
Copy link
Contributor Author

Hi @nscuro yeap the screenshot i attached is actually for IS_NOT testing. Thank you

@nscuro
Copy link
Member

nscuro commented Oct 26, 2024

An automated test in the file I linked would be preferable to ensure we're not breaking this behavior going forward.

@francislance
Copy link
Contributor Author

An automated test in the file I linked would be preferable to ensure we're not breaking this behavior going forward.

Alright. I will work on it.

lance.arzadon and others added 3 commits October 29, 2024 10:05
…entHashPolicyEvaluator

Signed-off-by: lance.arzadon <[email protected]>
Signed-off-by: Lance Arzadon <[email protected]>
Signed-off-by: francislance <[email protected]>
Signed-off-by: francislance <[email protected]>
@francislance francislance force-pushed the fix-component-hash-policy-evaluator branch from bab21f8 to f85607b Compare October 29, 2024 03:06
Copy link

codacy-production bot commented Oct 29, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.11% (target: -1.00%) 78.57% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (27f89b3) 22549 17853 79.17%
Head commit (dced0f4) 22564 (+15) 17841 (-12) 79.07% (-0.11%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4306) 14 11 78.57%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@francislance
Copy link
Contributor Author

Hi @nscuro please let me know if you need further actions on my side for this matter. Thank you

Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks @francislance!

@nscuro nscuro merged commit 0737b1d into DependencyTrack:master Nov 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants