-
-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix component hash policy evaluator #4306
Fix component hash policy evaluator #4306
Conversation
22101c9
to
c4d5820
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @francislance! Could you please add a test for the IS_NOT
operator?
Hi @nscuro yeap the screenshot i attached is actually for IS_NOT testing. Thank you |
An automated test in the file I linked would be preferable to ensure we're not breaking this behavior going forward. |
Alright. I will work on it. |
Signed-off-by: lance.arzadon <[email protected]> Signed-off-by: francislance <[email protected]>
…entHashPolicyEvaluator Signed-off-by: lance.arzadon <[email protected]> Signed-off-by: Lance Arzadon <[email protected]> Signed-off-by: francislance <[email protected]>
Signed-off-by: francislance <[email protected]>
bab21f8
to
f85607b
Compare
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Signed-off-by: francislance <[email protected]>
Hi @nscuro please let me know if you need further actions on my side for this matter. Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, thanks @francislance!
Description
This is for Component Hash policy condition only supports positive matches #4230
Addressed Issue
Component Hash policy condition only supports positive matches #4230
Additional Details
Local Testing Screenshots:
Checklist
This PR introduces changes to the database model, and I have added corresponding [update logic](https://github.com/DependencyTrack/dependency-track/tree/master/src/main/java/org/dependencytrack/upgrade)