Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect CWE schema in OpenAPI spec #4350

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

fupgang
Copy link
Contributor

@fupgang fupgang commented Nov 4, 2024

Description

Added annotation for OpenAPI description.

Addressed Issue

Fixes #4349

Additional Details

Now produces:

"Vulnerability" : {

          "cwes" : {
            "type" : "array",
            "items" : {
              "$ref" : "#/components/schemas/Cwe"
            }
          },

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@nscuro nscuro changed the title fixes #4349 Fix incorrect CWE schema in OpenAPI spec Nov 5, 2024
@nscuro nscuro added defect Something isn't working api docs backport/4.12.2 PRs to be backported to version 4.12.2 labels Nov 5, 2024
@nscuro nscuro added this to the 4.13 milestone Nov 5, 2024
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8547447) 22551 17839 79.11%
Head commit (6c8fb30) 22551 (+0) 17839 (+0) 79.11% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4350) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro nscuro merged commit f06d64f into DependencyTrack:master Nov 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api docs backport/4.12.2 PRs to be backported to version 4.12.2 defect Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenApi schema for Vulnerability misses conversion of CWEs
2 participants